You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2004/08/02 21:05:23 UTC

[jira] Created: (MPECLIPSE-36) [PATCH] JUnit jar not add in a specific condition

Message:

  A new issue has been created in JIRA.

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPECLIPSE-36

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPECLIPSE-36
    Summary: [PATCH] JUnit jar not add in a specific condition
       Type: Bug

     Status: Unassigned
   Priority: Major

 Original Estimate: 15 minutes
 Time Spent: Unknown
  Remaining: 15 minutes

    Project: maven-eclipse-plugin
   Versions:
             1.8

   Assignee: 
   Reporter: Felipe Leme

    Created: Mon, 2 Aug 2004 3:03 PM
    Updated: Mon, 2 Aug 2004 3:03 PM

Description:
If your project doesn't have a <unitTestSourceDirectory> in the POM, the JUnit jar is never included, even if it used by other classes (like Cactus testcases). The reason is the following code:
      
<j:when test="${lib.dependency.groupId == 'junit' }">
  <!-- ignoring junit dependency as we've already created it -->
</j:when>

This is not always true, because junit dependency is added inside the following statement:

  <j:if test="${unitTestSourcesPresent}">
....
....

So, I'm providing a quick fix for this situation.      


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MPECLIPSE-36) [PATCH] JUnit jar not add in a specific condition

Posted by ji...@codehaus.org.
The following issue has been updated:

    Updater: Felipe Leme (mailto:jira@felipeal.net)
       Date: Mon, 2 Aug 2004 3:05 PM
    Comment:
A simple fix for this issue.
    Changes:
             Attachment changed to mpeclipse-36.patch
    ---------------------------------------------------------------------
For a full history of the issue, see:

  http://jira.codehaus.org/browse/MPECLIPSE-36?page=history

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPECLIPSE-36

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPECLIPSE-36
    Summary: [PATCH] JUnit jar not add in a specific condition
       Type: Bug

     Status: Unassigned
   Priority: Major

 Original Estimate: 15 minutes
 Time Spent: Unknown
  Remaining: 15 minutes

    Project: maven-eclipse-plugin
   Versions:
             1.8

   Assignee: 
   Reporter: Felipe Leme

    Created: Mon, 2 Aug 2004 3:03 PM
    Updated: Mon, 2 Aug 2004 3:05 PM

Description:
If your project doesn't have a <unitTestSourceDirectory> in the POM, the JUnit jar is never included, even if it used by other classes (like Cactus testcases). The reason is the following code:
      
<j:when test="${lib.dependency.groupId == 'junit' }">
  <!-- ignoring junit dependency as we've already created it -->
</j:when>

This is not always true, because junit dependency is added inside the following statement:

  <j:if test="${unitTestSourcesPresent}">
....
....

So, I'm providing a quick fix for this situation.      


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Closed: (MPECLIPSE-36) [PATCH] JUnit jar not add in a specific condition

Posted by ji...@codehaus.org.
Message:

   The following issue has been closed.

   Resolver: David Eric Pugh
       Date: Mon, 9 Aug 2004 10:35 AM

Thanks for the patch..  I also added a unit test for this.
---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPECLIPSE-36

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPECLIPSE-36
    Summary: [PATCH] JUnit jar not add in a specific condition
       Type: Bug

     Status: Closed
   Priority: Major
 Resolution: FIXED

 Original Estimate: 15 minutes
 Time Spent: Unknown
  Remaining: 15 minutes

    Project: maven-eclipse-plugin
   Fix Fors:
             1.8
   Versions:
             1.8

   Assignee: David Eric Pugh
   Reporter: Felipe Leme

    Created: Mon, 2 Aug 2004 3:03 PM
    Updated: Mon, 9 Aug 2004 10:35 AM

Description:
If your project doesn't have a <unitTestSourceDirectory> in the POM, the JUnit jar is never included, even if it used by other classes (like Cactus testcases). The reason is the following code:
      
<j:when test="${lib.dependency.groupId == 'junit' }">
  <!-- ignoring junit dependency as we've already created it -->
</j:when>

This is not always true, because junit dependency is added inside the following statement:

  <j:if test="${unitTestSourcesPresent}">
....
....

So, I'm providing a quick fix for this situation.      


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org