[GitHub] [pulsar] rdhabalia commented on a change in pull request #9292: [pulsar-broker] Support large number of unack message store for cursor recovery

[GitBox <gi...@apache.org>]

rdhabalia commented on a change in pull request #9292:
URL: https://github.com/apache/pulsar/pull/9292#discussion_r563563466



##########
File path: managed-ledger/src/main/proto/MLDataFormats.proto
##########
@@ -71,6 +71,9 @@ message PositionInfo {
 
     // Store which index in the batch message has been deleted
     repeated BatchedEntryDeletionIndexInfo batchedEntryDeletionIndexInfo = 5;
+
+    // serialized individualDeletedMessages
+    optional bytes serializedIndividualDeletedMessages = 6;

Review comment:
       I tried to think about it but I don't see a clean way to get an internal structure of `BitSet` or internal reference which we can use to encode to protobuf. So, only way, I can see is to seralize BitSet to byte array and use the same to deserialize, It also gives a flexibility if we want to make range-set pluggable which can have a different implementation and that range set serialization doesn't have to depend on any specific protobuf format.
   but please let me know if you have any recommendation which can allow us to encode it directly in protobuf




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org