You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/15 13:10:24 UTC
[GitHub] [apisix] nic-chen opened a new issue #2433: feature: add managed fields in jsonschema for resources, such as create_time and update_time
nic-chen opened a new issue #2433:
URL: https://github.com/apache/apisix/issues/2433
### Issue description
We are refactoring the dashboard `manager api`, to remove the dependency on MySQL. Previously, some managed fields were saved in mysql. After refactoring, we moved these fields to ETCD. I think APISIX's json schema should also support this part of the fields to avoid data being filtered out.
Here is the detail:
create_time and update_time for `route`,`upstream`,`service`,`consumer`,`ssl`
validity_start and validity_end for `ssl`
this four fields are all int type for Unix timestamp.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen commented on issue #2433: feature: add managed fields in jsonschema for resources, such as create_time and update_time
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #2433:
URL: https://github.com/apache/apisix/issues/2433#issuecomment-709314203
cc @moonming @membphis @ShiningRush
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2433: feature: add managed fields in jsonschema for resources, such as create_time and update_time
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #2433:
URL: https://github.com/apache/apisix/issues/2433#issuecomment-709977324
agree to add the new field ^_^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis edited a comment on issue #2433: feature: add managed fields in jsonschema for resources, such as create_time and update_time
Posted by GitBox <gi...@apache.org>.
membphis edited a comment on issue #2433:
URL: https://github.com/apache/apisix/issues/2433#issuecomment-709382782
@nic-chen can you provide some examples?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen commented on issue #2433: feature: add managed fields in jsonschema for resources, such as create_time and update_time
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #2433:
URL: https://github.com/apache/apisix/issues/2433#issuecomment-709678753
@membphis
example, add create_time and update_time for `service`
```
local timestamp_def = {
type = "integer",
}
_M.service = {
type = "object",
properties = {
id = id_schema,
plugins = plugins_schema,
upstream = upstream_schema,
upstream_id = id_schema,
name = {type = "string", maxLength = 50},
desc = {type = "string", maxLength = 256},
script = {type = "string", minLength = 10, maxLength = 102400},
labels = {
description = "key/value pairs to specify attributes",
type = "object",
patternProperties = {
[".*"] = label_value_def
},
maxProperties = 16
},
create_time = timestamp_def,
update_time = timestamp_def
},
additionalProperties = false,
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2433: feature: add managed fields in jsonschema for resources, such as create_time and update_time
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #2433:
URL: https://github.com/apache/apisix/issues/2433#issuecomment-711000462
fixed alread
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] dabue commented on issue #2433: feature: add managed fields in jsonschema for resources, such as create_time and update_time
Posted by GitBox <gi...@apache.org>.
dabue commented on issue #2433:
URL: https://github.com/apache/apisix/issues/2433#issuecomment-710980509
+1， or add a field version.
88786912@qq.com
From: YuanSheng Wang
Date: 2020-10-16 19:00
To: apache/apisix
CC: Subscribed
Subject: Re: [apache/apisix] feature: add managed fields in jsonschema for resources, such as create_time and update_time (#2433)
agree to add the new field ^_^
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2433: feature: add managed fields in jsonschema for resources, such as create_time and update_time
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #2433:
URL: https://github.com/apache/apisix/issues/2433#issuecomment-709701800
@nic-chen do we need to add `create_time` and `update_time` for all object? eg: `service`, `route` and `consumer` etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen commented on issue #2433: feature: add managed fields in jsonschema for resources, such as create_time and update_time
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #2433:
URL: https://github.com/apache/apisix/issues/2433#issuecomment-709702786
> @nic-chen do we need to add `create_time` and `update_time` for all object? eg: `service`, `route` and `consumer` etc.
yes, i think so. if not, data will be filter by :
https://github.com/apache/apisix/blob/master/apisix/core/config_etcd.lua#L220-L226
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2433: feature: add managed fields in jsonschema for resources, such as create_time and update_time
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #2433:
URL: https://github.com/apache/apisix/issues/2433#issuecomment-709382782
@nic-chen can you provide some examples? we need this for confirming.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis closed issue #2433: feature: add managed fields in jsonschema for resources, such as create_time and update_time
Posted by GitBox <gi...@apache.org>.
membphis closed issue #2433:
URL: https://github.com/apache/apisix/issues/2433
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org