You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Julian Reschke (JIRA)" <ji...@apache.org> on 2008/04/02 11:56:25 UTC
[jira] Created: (JCR-1513) RepositoryService.checkin should return
information about newly created version
RepositoryService.checkin should return information about newly created version
-------------------------------------------------------------------------------
Key: JCR-1513
URL: https://issues.apache.org/jira/browse/JCR-1513
Project: Jackrabbit
Issue Type: Improvement
Components: jackrabbit-spi
Reporter: Julian Reschke
We have a mismatch between Node.checkin(), which returns a new Version object, and RepositoryService.checkin(), which returns void.
Client of SPI, such as JCR2SPI, thus will have to make an additional request for the base version property, with the obvious drawbacks (another call, and a potential cause for a race condition).
Proposal: change the return code to NodeId.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (JCR-1513) RepositoryService.checkin should return
information about newly created version
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke reassigned JCR-1513:
-----------------------------------
Assignee: (was: Julian Reschke)
> RepositoryService.checkin should return information about newly created version
> -------------------------------------------------------------------------------
>
> Key: JCR-1513
> URL: https://issues.apache.org/jira/browse/JCR-1513
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-spi
> Reporter: Julian Reschke
>
> We have a mismatch between Node.checkin(), which returns a new Version object, and RepositoryService.checkin(), which returns void.
> Client of SPI, such as JCR2SPI, thus will have to make an additional request for the base version property, with the obvious drawbacks (another call, and a potential cause for a race condition).
> Proposal: change the return code to NodeId.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-1513) RepositoryService.checkin should return
information about newly created version
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela resolved JCR-1513.
-------------------------
Resolution: Fixed
step 3) completed at rev. 649276
> RepositoryService.checkin should return information about newly created version
> -------------------------------------------------------------------------------
>
> Key: JCR-1513
> URL: https://issues.apache.org/jira/browse/JCR-1513
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-spi
> Reporter: Julian Reschke
> Assignee: Julian Reschke
>
> We have a mismatch between Node.checkin(), which returns a new Version object, and RepositoryService.checkin(), which returns void.
> Client of SPI, such as JCR2SPI, thus will have to make an additional request for the base version property, with the obvious drawbacks (another call, and a potential cause for a race condition).
> Proposal: change the return code to NodeId.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1513) RepositoryService.checkin should
return information about newly created version
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590104#action_12590104 ]
angela commented on JCR-1513:
-----------------------------
fixed in the sandbox:
- spi-logger
- spi-rmi
- spi2dav
with rev. 649183.
regarding 3)... julian when would you like to change that?
i would either skip 3) at all (allow null return) or forbid null return right from the beginning.
what do you think?
angela
> RepositoryService.checkin should return information about newly created version
> -------------------------------------------------------------------------------
>
> Key: JCR-1513
> URL: https://issues.apache.org/jira/browse/JCR-1513
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-spi
> Reporter: Julian Reschke
> Assignee: angela
>
> We have a mismatch between Node.checkin(), which returns a new Version object, and RepositoryService.checkin(), which returns void.
> Client of SPI, such as JCR2SPI, thus will have to make an additional request for the base version property, with the obvious drawbacks (another call, and a potential cause for a race condition).
> Proposal: change the return code to NodeId.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (JCR-1513) RepositoryService.checkin should return
information about newly created version
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke reassigned JCR-1513:
-----------------------------------
Assignee: Julian Reschke
> RepositoryService.checkin should return information about newly created version
> -------------------------------------------------------------------------------
>
> Key: JCR-1513
> URL: https://issues.apache.org/jira/browse/JCR-1513
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-spi
> Reporter: Julian Reschke
> Assignee: Julian Reschke
>
> We have a mismatch between Node.checkin(), which returns a new Version object, and RepositoryService.checkin(), which returns void.
> Client of SPI, such as JCR2SPI, thus will have to make an additional request for the base version property, with the obvious drawbacks (another call, and a potential cause for a race condition).
> Proposal: change the return code to NodeId.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1513) RepositoryService.checkin should return
information about newly created version
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-1513:
-------------------------------
Fix Version/s: 1.5.0
> RepositoryService.checkin should return information about newly created version
> -------------------------------------------------------------------------------
>
> Key: JCR-1513
> URL: https://issues.apache.org/jira/browse/JCR-1513
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-spi
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Fix For: 1.5.0
>
>
> We have a mismatch between Node.checkin(), which returns a new Version object, and RepositoryService.checkin(), which returns void.
> Client of SPI, such as JCR2SPI, thus will have to make an additional request for the base version property, with the obvious drawbacks (another call, and a potential cause for a race condition).
> Proposal: change the return code to NodeId.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1513) RepositoryService.checkin should
return information about newly created version
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590106#action_12590106 ]
Julian Reschke commented on JCR-1513:
-------------------------------------
It was supposed to make the deployment of the change easier.
If we now have all impls actually doing this, I can execute step 3.
> RepositoryService.checkin should return information about newly created version
> -------------------------------------------------------------------------------
>
> Key: JCR-1513
> URL: https://issues.apache.org/jira/browse/JCR-1513
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-spi
> Reporter: Julian Reschke
> Assignee: angela
>
> We have a mismatch between Node.checkin(), which returns a new Version object, and RepositoryService.checkin(), which returns void.
> Client of SPI, such as JCR2SPI, thus will have to make an additional request for the base version property, with the obvious drawbacks (another call, and a potential cause for a race condition).
> Proposal: change the return code to NodeId.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1513) RepositoryService.checkin should
return information about newly created version
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589591#action_12589591 ]
Julian Reschke commented on JCR-1513:
-------------------------------------
Proposal:
1) Allow checkin to return a NodeId *or* null (for easier migration of existing SPI impls)
2) Use the non-null return value in JCR2SPI to avoid fetching the base version.
Then finally:
3) Get rid of the support for null return values.
> RepositoryService.checkin should return information about newly created version
> -------------------------------------------------------------------------------
>
> Key: JCR-1513
> URL: https://issues.apache.org/jira/browse/JCR-1513
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-spi
> Reporter: Julian Reschke
> Assignee: Julian Reschke
>
> We have a mismatch between Node.checkin(), which returns a new Version object, and RepositoryService.checkin(), which returns void.
> Client of SPI, such as JCR2SPI, thus will have to make an additional request for the base version property, with the obvious drawbacks (another call, and a potential cause for a race condition).
> Proposal: change the return code to NodeId.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1513) RepositoryService.checkin should
return information about newly created version
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12584572#action_12584572 ]
angela commented on JCR-1513:
-----------------------------
no objections. we originally had it but then got rid of the return values and later on, re-added
a return value to the merge equivalent... so, having it for checkin would be find with me as well.
> RepositoryService.checkin should return information about newly created version
> -------------------------------------------------------------------------------
>
> Key: JCR-1513
> URL: https://issues.apache.org/jira/browse/JCR-1513
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-spi
> Reporter: Julian Reschke
>
> We have a mismatch between Node.checkin(), which returns a new Version object, and RepositoryService.checkin(), which returns void.
> Client of SPI, such as JCR2SPI, thus will have to make an additional request for the base version property, with the obvious drawbacks (another call, and a potential cause for a race condition).
> Proposal: change the return code to NodeId.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (JCR-1513) RepositoryService.checkin should return
information about newly created version
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke reassigned JCR-1513:
-----------------------------------
Assignee: angela (was: Julian Reschke)
> RepositoryService.checkin should return information about newly created version
> -------------------------------------------------------------------------------
>
> Key: JCR-1513
> URL: https://issues.apache.org/jira/browse/JCR-1513
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-spi
> Reporter: Julian Reschke
> Assignee: angela
>
> We have a mismatch between Node.checkin(), which returns a new Version object, and RepositoryService.checkin(), which returns void.
> Client of SPI, such as JCR2SPI, thus will have to make an additional request for the base version property, with the obvious drawbacks (another call, and a potential cause for a race condition).
> Proposal: change the return code to NodeId.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (JCR-1513) RepositoryService.checkin should return
information about newly created version
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke reassigned JCR-1513:
-----------------------------------
Assignee: Julian Reschke
> RepositoryService.checkin should return information about newly created version
> -------------------------------------------------------------------------------
>
> Key: JCR-1513
> URL: https://issues.apache.org/jira/browse/JCR-1513
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-spi
> Reporter: Julian Reschke
> Assignee: Julian Reschke
>
> We have a mismatch between Node.checkin(), which returns a new Version object, and RepositoryService.checkin(), which returns void.
> Client of SPI, such as JCR2SPI, thus will have to make an additional request for the base version property, with the obvious drawbacks (another call, and a potential cause for a race condition).
> Proposal: change the return code to NodeId.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (JCR-1513) RepositoryService.checkin should return
information about newly created version
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke reassigned JCR-1513:
-----------------------------------
Assignee: Julian Reschke (was: angela)
> RepositoryService.checkin should return information about newly created version
> -------------------------------------------------------------------------------
>
> Key: JCR-1513
> URL: https://issues.apache.org/jira/browse/JCR-1513
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-spi
> Reporter: Julian Reschke
> Assignee: Julian Reschke
>
> We have a mismatch between Node.checkin(), which returns a new Version object, and RepositoryService.checkin(), which returns void.
> Client of SPI, such as JCR2SPI, thus will have to make an additional request for the base version property, with the obvious drawbacks (another call, and a potential cause for a race condition).
> Proposal: change the return code to NodeId.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1513) RepositoryService.checkin should
return information about newly created version
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590009#action_12590009 ]
Julian Reschke commented on JCR-1513:
-------------------------------------
Implemented as proposed with revision #649071 and #649073; handing over to Angela for changes in Sandbox.
> RepositoryService.checkin should return information about newly created version
> -------------------------------------------------------------------------------
>
> Key: JCR-1513
> URL: https://issues.apache.org/jira/browse/JCR-1513
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-spi
> Reporter: Julian Reschke
> Assignee: Julian Reschke
>
> We have a mismatch between Node.checkin(), which returns a new Version object, and RepositoryService.checkin(), which returns void.
> Client of SPI, such as JCR2SPI, thus will have to make an additional request for the base version property, with the obvious drawbacks (another call, and a potential cause for a race condition).
> Proposal: change the return code to NodeId.
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.