You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2025/02/26 22:43:18 UTC

[Impala-ASF-CR] IMPALA-13804: Use redacted statement in live table

Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22556


Change subject: IMPALA-13804: Use redacted statement in live table
......................................................................

IMPALA-13804: Use redacted statement in live table

Uses the redacted SQL statement in sys.impala_query_live, so it's
consistent with the profile and sys.impala_query_log.

Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Testing: added a test with redaction rules for live and log tables.
---
M be/src/exec/system-table-scanner.cc
A testdata/workload_mgmt/redaction.json
M tests/custom_cluster/test_query_live.py
M tests/custom_cluster/test_query_log.py
M tests/util/workload_management.py
5 files changed, 51 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/22556/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-13804: Use redacted statement in live table

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22556 )

Change subject: IMPALA-13804: Use redacted statement in live table
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/22556/3/testdata/workload_mgmt/redaction.json
File testdata/workload_mgmt/redaction.json:

http://gerrit.cloudera.org:8080/#/c/22556/3/testdata/workload_mgmt/redaction.json@11
PS3, Line 11: }
            :   
> Is this JSON misaligned?
Done


http://gerrit.cloudera.org:8080/#/c/22556/3/tests/custom_cluster/test_query_log.py
File tests/custom_cluster/test_query_log.py:

http://gerrit.cloudera.org:8080/#/c/22556/3/tests/custom_cluster/test_query_log.py@37
PS3, Line 37: from tests.util.workload_management import (
            :     assert_query,
> nit: Consider breaking line after open parenthesis.
Done


http://gerrit.cloudera.org:8080/#/c/22556/3/tests/util/workload_management.py
File tests/util/workload_management.py:

http://gerrit.cloudera.org:8080/#/c/22556/3/tests/util/workload_management.py@712
PS3, Line 712:   """Provides the path to a redaction file that redacts the word
> Please add comment describing what this JSON file is trying to redact.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/22556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 23:37:43 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13804: Use redacted statement in live table

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22556 )

Change subject: IMPALA-13804: Use redacted statement in live table
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/18403/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 00:03:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13804: Use redacted statement in live table

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Riza Suminto, Jason Fehr, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22556

to look at the new patch set (#6).

Change subject: IMPALA-13804: Use redacted statement in live table
......................................................................

IMPALA-13804: Use redacted statement in live table

Uses the redacted SQL statement in sys.impala_query_live, so it's
consistent with the profile and sys.impala_query_log.

Testing: added a test with redaction rules for live and log tables.

Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
---
M be/src/exec/system-table-scanner.cc
A testdata/workload_mgmt/redaction.json
M tests/custom_cluster/test_query_live.py
M tests/custom_cluster/test_query_log.py
M tests/util/workload_management.py
5 files changed, 56 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/22556/6
-- 
To view, visit http://gerrit.cloudera.org:8080/22556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13804: Use redacted statement in live table

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22556 )

Change subject: IMPALA-13804: Use redacted statement in live table
......................................................................


Patch Set 8: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 22:39:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13804: Use redacted statement in live table

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22556 )

Change subject: IMPALA-13804: Use redacted statement in live table
......................................................................


Patch Set 1:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/22556/1/tests/util/workload_management.py
File tests/util/workload_management.py:

http://gerrit.cloudera.org:8080/#/c/22556/1/tests/util/workload_management.py@710
PS1, Line 710: def redaction_rules_file():
flake8: E302 expected 2 blank lines, found 1



-- 
To view, visit http://gerrit.cloudera.org:8080/22556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 22:46:10 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13804: Use redacted statement in live table

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22556 )

Change subject: IMPALA-13804: Use redacted statement in live table
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/18404/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 00:05:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13804: Use redacted statement in live table

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22556 )

Change subject: IMPALA-13804: Use redacted statement in live table
......................................................................


Patch Set 6: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22556/6/tests/util/workload_management.py
File tests/util/workload_management.py:

http://gerrit.cloudera.org:8080/#/c/22556/6/tests/util/workload_management.py@714
PS6, Line 714: os.environ["IMPALA_HOME"]
nit: There is an IMPALA_HOME in environ.py

from tests.common.environ import IMPALA_HOME



-- 
To view, visit http://gerrit.cloudera.org:8080/22556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 23:50:53 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13804: Use redacted statement in live table

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22556 )

Change subject: IMPALA-13804: Use redacted statement in live table
......................................................................


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11523/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/22556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 04:41:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13804: Use redacted statement in live table

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22556 )

Change subject: IMPALA-13804: Use redacted statement in live table
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22556/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22556/2//COMMIT_MSG@12
PS2, Line 12: Testing: added a test with redaction rules for live and log tables.
> Please move the Change-Id to be the last line of the commit message.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/22556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 22:59:57 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13804: Use redacted statement in live table

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Riza Suminto, Jason Fehr, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22556

to look at the new patch set (#5).

Change subject: IMPALA-13804: Use redacted statement in live table
......................................................................

IMPALA-13804: Use redacted statement in live table

Uses the redacted SQL statement in sys.impala_query_live, so it's
consistent with the profile and sys.impala_query_log.

Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Testing: added a test with redaction rules for live and log tables.
---
M be/src/exec/system-table-scanner.cc
A testdata/workload_mgmt/redaction.json
M tests/custom_cluster/test_query_live.py
M tests/custom_cluster/test_query_log.py
M tests/util/workload_management.py
5 files changed, 56 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/22556/5
-- 
To view, visit http://gerrit.cloudera.org:8080/22556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13804: Use redacted statement in live table

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22556 )

Change subject: IMPALA-13804: Use redacted statement in live table
......................................................................


Patch Set 7: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 04:41:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13804: Use redacted statement in live table

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22556 )

Change subject: IMPALA-13804: Use redacted statement in live table
......................................................................


Patch Set 3: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 23:20:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13804: Use redacted statement in live table

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Jason Fehr, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22556

to look at the new patch set (#2).

Change subject: IMPALA-13804: Use redacted statement in live table
......................................................................

IMPALA-13804: Use redacted statement in live table

Uses the redacted SQL statement in sys.impala_query_live, so it's
consistent with the profile and sys.impala_query_log.

Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Testing: added a test with redaction rules for live and log tables.
---
M be/src/exec/system-table-scanner.cc
A testdata/workload_mgmt/redaction.json
M tests/custom_cluster/test_query_live.py
M tests/custom_cluster/test_query_log.py
M tests/util/workload_management.py
5 files changed, 52 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/22556/2
-- 
To view, visit http://gerrit.cloudera.org:8080/22556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-13804: Use redacted statement in live table

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Jason Fehr, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22556

to look at the new patch set (#3).

Change subject: IMPALA-13804: Use redacted statement in live table
......................................................................

IMPALA-13804: Use redacted statement in live table

Uses the redacted SQL statement in sys.impala_query_live, so it's
consistent with the profile and sys.impala_query_log.

Testing: added a test with redaction rules for live and log tables.

Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
---
M be/src/exec/system-table-scanner.cc
A testdata/workload_mgmt/redaction.json
M tests/custom_cluster/test_query_live.py
M tests/custom_cluster/test_query_log.py
M tests/util/workload_management.py
5 files changed, 52 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/22556/3
-- 
To view, visit http://gerrit.cloudera.org:8080/22556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-13804: Use redacted statement in live table

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22556 )

Change subject: IMPALA-13804: Use redacted statement in live table
......................................................................


Patch Set 6: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22556/6/tests/util/workload_management.py
File tests/util/workload_management.py:

http://gerrit.cloudera.org:8080/#/c/22556/6/tests/util/workload_management.py@714
PS6, Line 714: os.environ["IMPALA_HOME"]
> nit: There is an IMPALA_HOME in environ.py
I didn't know about that constant.  I don't see where it's used though.  I see lots of os.environ['IMPALA_HOME'] though, thus I think we should stick with the established style and not use the IMPALA_HOME constant.



-- 
To view, visit http://gerrit.cloudera.org:8080/22556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 00:03:00 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13804: Use redacted statement in live table

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22556 )

Change subject: IMPALA-13804: Use redacted statement in live table
......................................................................


Patch Set 8: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 17:11:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13804: Use redacted statement in live table

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22556 )

Change subject: IMPALA-13804: Use redacted statement in live table
......................................................................

IMPALA-13804: Use redacted statement in live table

Uses the redacted SQL statement in sys.impala_query_live, so it's
consistent with the profile and sys.impala_query_log.

Testing: added a test with redaction rules for live and log tables.

Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Reviewed-on: http://gerrit.cloudera.org:8080/22556
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Jason Fehr <jf...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/system-table-scanner.cc
A testdata/workload_mgmt/redaction.json
M tests/custom_cluster/test_query_live.py
M tests/custom_cluster/test_query_log.py
M tests/util/workload_management.py
5 files changed, 56 insertions(+), 3 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified
  Jason Fehr: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/22556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13804: Use redacted statement in live table

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22556 )

Change subject: IMPALA-13804: Use redacted statement in live table
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/18402/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 23:09:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13804: Use redacted statement in live table

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22556 )

Change subject: IMPALA-13804: Use redacted statement in live table
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/18401/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 23:10:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13804: Use redacted statement in live table

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22556 )

Change subject: IMPALA-13804: Use redacted statement in live table
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/22556/3/testdata/workload_mgmt/redaction.json
File testdata/workload_mgmt/redaction.json:

http://gerrit.cloudera.org:8080/#/c/22556/3/testdata/workload_mgmt/redaction.json@11
PS3, Line 11:   }
            :   
Is this JSON misaligned?


http://gerrit.cloudera.org:8080/#/c/22556/3/tests/custom_cluster/test_query_log.py
File tests/custom_cluster/test_query_log.py:

http://gerrit.cloudera.org:8080/#/c/22556/3/tests/custom_cluster/test_query_log.py@37
PS3, Line 37: from tests.util.workload_management import (assert_query, WM_DB, QUERY_TBL_LOG,
            :                                             redaction_rules_file)
nit: Consider breaking line after open parenthesis.

from tests.util.workload_management import (
  assert_query,
  WM_DB,
  QUERY_TBL_LOG,
  redaction_rules_file)


http://gerrit.cloudera.org:8080/#/c/22556/3/tests/util/workload_management.py
File tests/util/workload_management.py:

http://gerrit.cloudera.org:8080/#/c/22556/3/tests/util/workload_management.py@712
PS3, Line 712:   return "{}/testdata/workload_mgmt/redaction.json".format(os.environ["IMPALA_HOME"])
Please add comment describing what this JSON file is trying to redact.



-- 
To view, visit http://gerrit.cloudera.org:8080/22556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 23:25:57 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13804: Use redacted statement in live table

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22556 )

Change subject: IMPALA-13804: Use redacted statement in live table
......................................................................


Patch Set 8:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11530/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/22556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 17:11:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13804: Use redacted statement in live table

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22556 )

Change subject: IMPALA-13804: Use redacted statement in live table
......................................................................


Patch Set 7: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11523/


-- 
To view, visit http://gerrit.cloudera.org:8080/22556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 10:07:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13804: Use redacted statement in live table

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Riza Suminto, Jason Fehr, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22556

to look at the new patch set (#4).

Change subject: IMPALA-13804: Use redacted statement in live table
......................................................................

IMPALA-13804: Use redacted statement in live table

Uses the redacted SQL statement in sys.impala_query_live, so it's
consistent with the profile and sys.impala_query_log.

Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Testing: added a test with redaction rules for live and log tables.
---
M be/src/exec/system-table-scanner.cc
A testdata/workload_mgmt/redaction.json
M tests/custom_cluster/test_query_live.py
M tests/custom_cluster/test_query_log.py
M tests/util/workload_management.py
5 files changed, 57 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/56/22556/4
-- 
To view, visit http://gerrit.cloudera.org:8080/22556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13804: Use redacted statement in live table

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22556 )

Change subject: IMPALA-13804: Use redacted statement in live table
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22556/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22556/2//COMMIT_MSG@12
PS2, Line 12: Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Please move the Change-Id to be the last line of the commit message.



-- 
To view, visit http://gerrit.cloudera.org:8080/22556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Feb 2025 22:56:08 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13804: Use redacted statement in live table

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22556 )

Change subject: IMPALA-13804: Use redacted statement in live table
......................................................................


Patch Set 8: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a72eeaea84981e96655aec6c67b5ef2cbbd3c3e
Gerrit-Change-Number: 22556
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 18:51:18 +0000
Gerrit-HasComments: No