[GitHub] [incubator-mxnet] ptrendx commented on a change in pull request #18104: Include broadcast_add into fused operators

[GitBox <gi...@apache.org>]

ptrendx commented on a change in pull request #18104:
URL: https://github.com/apache/incubator-mxnet/pull/18104#discussion_r413987136



##########
File path: src/operator/fusion/fused_op.cu
##########
@@ -253,11 +258,18 @@ std::string FusedOp::GenerateCode(const std::vector<OpReqType> &req,
         CHECK_EQ(outputs[i], 1);
       } else {
         std::string op_name = source->op()->name;
-        if (fusion::slice_ops.find(op_name) != fusion::slice_ops.end()) {
+        bool is_broadcast_op = fusion::broadcast_ops.find(op_name) != fusion::broadcast_ops.end();

Review comment:
       Why define it multiple times? Bring it (and also make `is_slice_op`) outside to the outer loop.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org