[GitHub] [arrow-datafusion] WinkerDu opened a new pull request, #2413: Make expected result string in unit tests more readable

[GitBox <gi...@apache.org>]

WinkerDu opened a new pull request, #2413:
URL: https://github.com/apache/arrow-datafusion/pull/2413

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #2412 .
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   Some unit tests in DataFusion organize expected result string vector in one line, like `sql::union::union_distinct` do
   ```
   #[tokio::test]
   async fn union_distinct() -> Result<()> {
       let ctx = SessionContext::new();
       let sql = "SELECT 1 as x UNION SELECT 1 as x";
       let actual = execute_to_batches(&ctx, sql).await;
       let expected = vec!["+---+", "| x |", "+---+", "| 1 |", "+---+"];
       assert_batches_eq!(expected, &actual);
       Ok(())
   }
   ```
   We can separate the expected result string vector into multiple line to make it more readable and easier to follow, by adding a `#[rustfmt::skip]` tag to skip fmt check as following code
   ```
   #[tokio::test]
   async fn union_distinct() -> Result<()> {
       let ctx = SessionContext::new();
       let sql = "SELECT 1 as x UNION SELECT 1 as x";
       let actual = execute_to_batches(&ctx, sql).await;
       #[rustfmt::skip]
       let expected = vec![
           "+---+",
           "| x |",
           "+---+",
           "| 1 |",
           "+---+"
       ];
       assert_batches_eq!(expected, &actual);
       Ok(())
   }
   ```
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   - Separates the expected result string vector into multiple line
   - adds a `#[rustfmt::skip]` tag to skip fmt check 
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   No.
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] andygrove merged pull request #2413: Make expected result string in unit tests more readable

[GitBox <gi...@apache.org>]

andygrove merged PR #2413:
URL: https://github.com/apache/arrow-datafusion/pull/2413


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org