You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2015/08/31 14:37:41 UTC
[GitHub] couchdb-fauxton pull request: fix login/logout with IE
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/509
fix login/logout with IE
disable caching for IE which prevents IE from logging in/out.
as IE starts to add cachebust-get-parameters when we disable ajax-
caching, i had to adjust the dev-server.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton ie11-my-love
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/509.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #509
----
commit 4029f99a9485033de3a8a913c088d9eec583d938
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-08-31T12:35:16Z
fix login/logout with IE
disable caching for IE which prevents IE from logging in/out.
as IE starts to add cachebust-get-parameters when we disable ajax-
caching, i had to adjust the dev-server.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fix login/logout with IE
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/509#issuecomment-136763191
meregd as 01650f62cacbb7110b35d368080a44c9d7d93fda
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fix login/logout with IE
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/509#issuecomment-136753440
This is pretty broad - disabling all request caching for the browser seems a little extreme. Any chance it could be made for the individual login/logout requests? I've ran into issues with IE's caching as well, but found it could be solved on a per-request level with a `whatever.fetch({ cache: false })`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fix login/logout with IE
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/509
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fix login/logout with IE
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/509#issuecomment-136757318
@benkeen
when we bundle the application for production, we create on big js file that is loaded once.
disabling caching for IE in this case means that we disable it just for all API calls to couch - which is the wanted behaviour as we don't want to show outdated data on databases, too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: fix login/logout with IE
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/509#issuecomment-136761129
This seems reasonable, thanks @robertkowalski! +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---