You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2020/03/15 22:27:18 UTC
[GitHub] [knox] smolnar82 opened a new pull request #289: KNOX-2295 - UI
services improvement on Knox Home page
smolnar82 opened a new pull request #289: KNOX-2295 - UI services improvement on Knox Home page
URL: https://github.com/apache/knox/pull/289
## What changes were proposed in this pull request?
Removed the data table when displaying UI services and using the services' logos with Angular's material grid. Long descriptions are shown by hovering over the short descriptions in the footer of each tile.
## How was this patch tested?
Tested manually; see these screenshots:
<img width="1671" alt="Screen Shot 2020-03-15 at 11 05 03 PM" src="https://user-images.githubusercontent.com/34065904/76711937-6d5c6500-6714-11ea-91af-7ccfaddb6faa.png">
<img width="1668" alt="Screen Shot 2020-03-15 at 11 12 25 PM" src="https://user-images.githubusercontent.com/34065904/76711939-70575580-6714-11ea-8d9a-5b08fdeb9467.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [knox] smolnar82 commented on issue #289: KNOX-2295 - UI services
improvement on Knox Home page
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on issue #289: KNOX-2295 - UI services improvement on Knox Home page
URL: https://github.com/apache/knox/pull/289#issuecomment-599273767
One comment: the Hue logo you are seeing in the above screenshot is replaced with one with white background.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [knox] smolnar82 commented on a change in pull request #289:
KNOX-2295 - UI services improvement on Knox Home page
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on a change in pull request #289: KNOX-2295 - UI services improvement on Knox Home page
URL: https://github.com/apache/knox/pull/289#discussion_r393089488
##########
File path: knox-homepage-ui/package.json
##########
@@ -10,11 +10,13 @@
},
"private": true,
"dependencies": {
+ "@angular/cdk": "^5.2.5",
Review comment:
I haven't tested with `5.2.0` as only `5.2.5` was listed as an officially supported version of Angular's material lib:
<img width="1672" alt="Screen Shot 2020-03-16 at 3 57 49 PM" src="https://user-images.githubusercontent.com/34065904/76771113-223b6400-679f-11ea-910f-d42a37fb4abc.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [knox] smolnar82 commented on issue #289: KNOX-2295 - UI services
improvement on Knox Home page
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on issue #289: KNOX-2295 - UI services improvement on Knox Home page
URL: https://github.com/apache/knox/pull/289#issuecomment-599629602
> @smolnar82 instead of "service logo comes here" can it instead be the text of the service? It would just be plain text on say a white background. That would probably look better.
So, we either use a static image (as of now; I'm open to change the text though) or try to find out if the referenced image exists and act differently (e.g. have a text on white background).
I don't think the general logo will appear as much; once someone realizes his logo is not displayed I'd imagine that he uploads one quickly -> the 2nd approach just not worth implementing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [knox] smolnar82 merged pull request #289: KNOX-2295 - UI services
improvement on Knox Home page
Posted by GitBox <gi...@apache.org>.
smolnar82 merged pull request #289: KNOX-2295 - UI services improvement on Knox Home page
URL: https://github.com/apache/knox/pull/289
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [knox] smolnar82 removed a comment on issue #289: KNOX-2295 - UI
services improvement on Knox Home page
Posted by GitBox <gi...@apache.org>.
smolnar82 removed a comment on issue #289: KNOX-2295 - UI services improvement on Knox Home page
URL: https://github.com/apache/knox/pull/289#issuecomment-599629602
> @smolnar82 instead of "service logo comes here" can it instead be the text of the service? It would just be plain text on say a white background. That would probably look better.
So, we either use a static image (as of now; I'm open to change the text though) or try to find out if the referenced image exists and act differently (e.g. have a text on white background).
I don't think the general logo will appear as much; once someone realizes his logo is not displayed I'd imagine that he uploads one quickly -> the 2nd approach just not worth implementing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [knox] risdenk commented on issue #289: KNOX-2295 - UI services
improvement on Knox Home page
Posted by GitBox <gi...@apache.org>.
risdenk commented on issue #289: KNOX-2295 - UI services improvement on Knox Home page
URL: https://github.com/apache/knox/pull/289#issuecomment-599626169
@smolnar82 instead of "service logo comes here" can it instead be the text of the service? It would just be plain text on say a white background. That would probably look better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [knox] smolnar82 edited a comment on issue #289: KNOX-2295 - UI
services improvement on Knox Home page
Posted by GitBox <gi...@apache.org>.
smolnar82 edited a comment on issue #289: KNOX-2295 - UI services improvement on Knox Home page
URL: https://github.com/apache/knox/pull/289#issuecomment-599603858
To address the logo stuff I figured out the following approach should work: I'll add a `general_logo.png` (with the text of 'Service Logo comes here') and display it for
- any service that does not have its own logo uploaded by this patch (anyone is free to upload their owns logos going forward as a separate patch)
- CM API/UI (because I'm going to remove the CM logo -> CM will fall into the above category)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [knox] smolnar82 commented on issue #289: KNOX-2295 - UI services
improvement on Knox Home page
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on issue #289: KNOX-2295 - UI services improvement on Knox Home page
URL: https://github.com/apache/knox/pull/289#issuecomment-599624692
This is how it looks like now:
<img width="1666" alt="Screen Shot 2020-03-16 at 5 09 48 PM" src="https://user-images.githubusercontent.com/34065904/76777996-616eb280-67a9-11ea-84c1-c00e9b4a6a65.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [knox] smolnar82 commented on issue #289: KNOX-2295 - UI services
improvement on Knox Home page
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on issue #289: KNOX-2295 - UI services improvement on Knox Home page
URL: https://github.com/apache/knox/pull/289#issuecomment-599603858
To address the logo stuff I figured out the following approach should work: I'll add a `general_logo.png` (with the text of 'Service Logo comes here') and display it for
- any service that does not have its own logo uploaded by this patch (anyone is free to upload their owns logos going forward as a separate patch)
- CM API/UI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [knox] smolnar82 commented on issue #289: KNOX-2295 - UI services
improvement on Knox Home page
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on issue #289: KNOX-2295 - UI services improvement on Knox Home page
URL: https://github.com/apache/knox/pull/289#issuecomment-599507005
Thanks, @moresandeep !
Trying to answer your comments:
1. I'll try to find a better CM logo
2. If there is no logo -> a JIRA should be submitted. I tried to add logos for all the actively used services.
3. Hue logo is replaced already (see my comment above)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [knox] risdenk commented on a change in pull request #289:
KNOX-2295 - UI services improvement on Knox Home page
Posted by GitBox <gi...@apache.org>.
risdenk commented on a change in pull request #289: KNOX-2295 - UI services improvement on Knox Home page
URL: https://github.com/apache/knox/pull/289#discussion_r393057400
##########
File path: knox-homepage-ui/package.json
##########
@@ -10,11 +10,13 @@
},
"private": true,
"dependencies": {
+ "@angular/cdk": "^5.2.5",
Review comment:
All the other angular versions is 5.2.0 but this is 5.2.5?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [knox] smolnar82 commented on issue #289: KNOX-2295 - UI services
improvement on Knox Home page
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on issue #289: KNOX-2295 - UI services improvement on Knox Home page
URL: https://github.com/apache/knox/pull/289#issuecomment-599585454
Regarding @risdenk 's comment on licensing: all service logos are logos of Apache projects except for the CM-[UI|API]. I understand his concerns about it and it's a valid question if we want to copy it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [knox] smolnar82 commented on issue #289: KNOX-2295 - UI services
improvement on Knox Home page
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on issue #289: KNOX-2295 - UI services improvement on Knox Home page
URL: https://github.com/apache/knox/pull/289#issuecomment-599661338
Newest version:
<img width="1678" alt="Screen Shot 2020-03-16 at 6 16 24 PM" src="https://user-images.githubusercontent.com/34065904/76783665-97fcfb00-67b2-11ea-9289-3fef58493425.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services