You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/03/28 17:44:13 UTC
[GitHub] dgrove-oss commented on a change in pull request #3497: allow singleton (active/passive) and replicated pools in invoker
dgrove-oss commented on a change in pull request #3497: allow singleton (active/passive) and replicated pools in invoker
URL: https://github.com/apache/incubator-openwhisk/pull/3497#discussion_r177818677
##########
File path: common/scala/src/main/scala/whisk/core/WhiskConfig.scala
##########
@@ -87,6 +87,7 @@ class WhiskConfig(requiredProperties: Map[String, String],
val actionInvokeSystemOverloadLimit = this(WhiskConfig.actionInvokeSystemOverloadLimit)
val actionSequenceLimit = this(WhiskConfig.actionSequenceMaxLimit)
val controllerSeedNodes = this(WhiskConfig.controllerSeedNodes)
+ val seedNodes = this(WhiskConfig.seedNodes)
Review comment:
`seedNodes` is pretty generic. Is the intent to eventually replace `controllerSeedNodes` with `seedNodes`, or would a more specific name be better to indicate the intended use of these `seedNodes` (vs. `controllerSeedNodes`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services