You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Apoorv Mittal (Jira)" <ji...@apache.org> on 2024/10/10 10:25:00 UTC
[jira] [Commented] (KAFKA-17760) Remove client instance from cache when received telemetry terminating request
[ https://issues.apache.org/jira/browse/KAFKA-17760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888226#comment-17888226 ]
Apoorv Mittal commented on KAFKA-17760:
---------------------------------------
[~chia7712] I have created this task as per the suggestion on the PR: [https://github.com/apache/kafka/pull/17431.]
The terminating flag do 2 things in broker:
# Allows the out of band telemetry push request i.e. the last telemetry push will be allowed irrespective of last push time and interval ms.
# To protect the downstream request processing, if once client sends teminating request then the same client can't send the telemetry request unless evicted from the cache.
If we remove the client the moment we receive terminating flag in broker, then a rogue client can send metrics with teminating as always true, and would not be throttled on push interval.
Though we can always debate that numerous new client instance can always be created to send a lot telemetry requests to broker but that's a separate issue which is dealth with client cache limit and overall client request throttling quota.
But the longer cache despite terminating flag protects us from a single rogue client.
[~chia7712] Do you still think we should remove the client instance from cache on terminating? I think we shouldn't.
> Remove client instance from cache when received telemetry terminating request
> -----------------------------------------------------------------------------
>
> Key: KAFKA-17760
> URL: https://issues.apache.org/jira/browse/KAFKA-17760
> Project: Kafka
> Issue Type: Improvement
> Reporter: Apoorv Mittal
> Assignee: Apoorv Mittal
> Priority: Major
>
> https://github.com/apache/kafka/pull/17431#pullrequestreview-2359513693
--
This message was sent by Atlassian Jira
(v8.20.10#820010)