You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by dkuppitz <gi...@git.apache.org> on 2015/02/12 00:51:36 UTC
[GitHub] incubator-tinkerpop pull request: Apache refactoring
GitHub user dkuppitz opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/10
Apache refactoring
* all tests passed
* history is preserved (note that it's not shown in GitHub's history view, but you can see everything in the Blame view)
* CHANGELOG.asciidoc and README.asciidoc are the only files that were not processed automatically (TODO: check)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dkuppitz/incubator-tinkerpop apache
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/10.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10
----
commit 84e0a9f8502c4faa6f17eabed5dbec32cc569fc0
Author: Daniel Kuppitz <da...@hotmail.com>
Date: 2015-02-11T23:36:25Z
moved com/tinkerpop directories to org/apache/tinkerpop
commit 0ddf57a81bec43185dc0e286cd917b18a554a365
Author: Daniel Kuppitz <da...@hotmail.com>
Date: 2015-02-11T23:36:26Z
renamed com.tinkerpop.* files to org.apache.tinkerpop.*
commit e71f214b391f9c8fde7d04cdd2dcb9a716c56da8
Author: Daniel Kuppitz <da...@hotmail.com>
Date: 2015-02-11T23:36:27Z
replaced namespace com.tinkerpop with org.apache.tinkerpop
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Apache refactoring
Posted by paliwalashish <gi...@git.apache.org>.
Github user paliwalashish commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/10#issuecomment-74002392
+1 I hope config file changes including docs have been taken care of
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Apache refactoring
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/10#issuecomment-74053664
I went through the docs, looks all good. In fact I've found a bug, but it's not related to the refactoring. But since we now have a merge conflict again, I will probably create another PR (no big deal, the refactoring is fully automated). @spmallette and/or @okram ping me if it makes sense to create another PR (you shouldn't have any pending commits).
Regarding the bug: ```the-graphcomputer.asciidoc``` contains a few occurences of ```.singleProperty(...)```.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: Apache refactoring
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/10
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---