You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by aharbick <gi...@git.apache.org> on 2014/09/25 22:52:13 UTC

[GitHub] cordova-ios pull request: Pass devicetypeid instead of --target to...

GitHub user aharbick opened a pull request:

    https://github.com/apache/cordova-ios/pull/107

    Pass devicetypeid instead of --target to match changes to ios-sim

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aharbick/cordova-ios master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/107.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #107
    
----
commit 7bffd7232891ca2d327ced20a4a725fdd6a2dfa1
Author: aharbick@aharbick.com <ah...@aharbick.com>
Date:   2014-09-25T19:09:22Z

    Pass devicetypeid instead of --target to match changes to ios-sim

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-ios pull request: Pass devicetypeid instead of --target to...

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-ios/pull/107#issuecomment-58249881
  
    We'll drop Xcode 5 support when OS X Yosemite 10.10 is released at the end of Oct 2014.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-ios pull request: Pass devicetypeid instead of --target to...

Posted by aharbick <gi...@git.apache.org>.
Github user aharbick commented on the pull request:

    https://github.com/apache/cordova-ios/pull/107#issuecomment-57051612
  
    Thanks @shazron.  I can figure out how to do 1. above (I assume there are other examples in the code base)...  How should we figure out 2.?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-ios pull request: Pass devicetypeid instead of --target to...

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-ios/pull/107#issuecomment-57030338
  
    This is nice, thanks!
    
    However, this has two pre-requisites, which we need to enforce first in the script and overall:
    1. ios-sim version 3.0.0
    2. Xcode 6 
    
    The first is easy, the second, requires a mailing list discussion. Since Apple hasn't required Xcode 6 definitively (yet), not sure, but we definitely can require Xcode 6 if everyone agrees.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-ios pull request: Pass devicetypeid instead of --target to...

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-ios/pull/107#issuecomment-58250499
  
    Filed https://issues.apache.org/jira/browse/CB-7729


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-ios pull request: Pass devicetypeid instead of --target to...

Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:

    https://github.com/apache/cordova-ios/pull/107#issuecomment-56921597
  
    Nice!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-ios pull request: Pass devicetypeid instead of --target to...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-ios/pull/107


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-ios pull request: Pass devicetypeid instead of --target to...

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-ios/pull/107#issuecomment-57064908
  
    Hi @aharbick - this will be entirely up to the committers of the project. I've already put out a thread (http://markmail.org/message/yaqehnt5nz5wlli7) to dev@cordova.apache.org for comment, probably by the end of the week we might have consensus.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-ios pull request: Pass devicetypeid instead of --target to...

Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:

    https://github.com/apache/cordova-ios/pull/107#issuecomment-56887608
  
    I don't think you need to go so far as requiring users to specify the entire namespace ... com.apple.CoreSimulator.SimDeviceType is completely meaningless if we are calling ios already.
    
    Consider this pull request as well ... https://github.com/apache/cordova-wp8/pull/59



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-ios pull request: Pass devicetypeid instead of --target to...

Posted by aharbick <gi...@git.apache.org>.
Github user aharbick commented on the pull request:

    https://github.com/apache/cordova-ios/pull/107#issuecomment-57065302
  
    Great.  That's what I was wondering (how to start the thread).  Thanks!
    
    
    
    > On Sep 27, 2014, at 4:35 PM, Shazron Abdullah <no...@github.com> wrote:
    > 
    > Hi @aharbick - this will be entirely up to the committers of the project. I've already put out a thread (http://markmail.org/message/yaqehnt5nz5wlli7) to dev@cordova.apache.org for comment, probably by the end of the week we might have consensus.
    > 
    > —
    > Reply to this email directly or view it on GitHub.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-ios pull request: Pass devicetypeid instead of --target to...

Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:

    https://github.com/apache/cordova-ios/pull/107#issuecomment-56887052
  
    The param should still be called --target to match other platforms.
    How you treat the --target, and what constitutes a valid --target are completely up to the platform, but keep the rest consistent. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---