[jira] Commented: (FILEUPLOAD-139) [fileupload] separator of boundary doesnt match rfc1867 examples

["Jochen Wiedmann (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FILEUPLOAD-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524848 ] 

Jochen Wiedmann commented on FILEUPLOAD-139:
--------------------------------------------

After reviewing, I can't fight the feeling, that the ParameterParser could use some refactoring in order to reduce the number of similar methods. However, IMO, we should reuse mime4j in the next version anyways, so that can be ignored for now. Go on, Henri!


> [fileupload] separator of boundary doesnt match rfc1867 examples
> ----------------------------------------------------------------
>
>                 Key: FILEUPLOAD-139
>                 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-139
>             Project: Commons FileUpload
>          Issue Type: Bug
>            Reporter: martynas
>             Fix For: 1.2.1
>
>         Attachments: FILEUPLOAD-139.patch
>
>
> [fileupload]
> in class :
> package org.apache.commons.fileupload;
> public abstract class FileUploadBase {
>     protected byte[] getBoundary(String contentType) {
>         ParameterParser parser = new ParameterParser();
>         parser.setLowerCaseNames(true);
>         // Parameter parser can handle null input
>         Map params = parser.parse(contentType, ';');
>         String boundaryStr = (String) params.get("boundary");
>         if (boundaryStr == null) {
>             return null;
>         }
>         byte[] boundary;
>         try {
>             boundary = boundaryStr.getBytes("ISO-8859-1");
>         } catch (UnsupportedEncodingException e) {
>             boundary = boundaryStr.getBytes();
>         }
>         return boundary;
>     }
> }
> String :  Map params = parser.parse(contentType, ';');
> doesn't match http://www.ietf.org/rfc/rfc1867.txt document
> because in all examples:
> Content-type: multipart/form-data , boundary=AaB03x
> Content-type: multipart/form-data, boundary=AaB03x
> Content-type: multipart/mixed, boundary=BbC04y
> boundary separated by comma (but not semicolon)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.