You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by da...@apache.org on 2017/07/02 05:59:04 UTC
svn commit: r1800547 - /subversion/trunk/tools/dist/release.py
Author: danielsh
Date: Sun Jul 2 05:59:04 2017
New Revision: 1800547
URL: http://svn.apache.org/viewvc?rev=1800547&view=rev
Log:
release.py: Revert r934990.
* tools/dist/release.py
(get_siginfo): Follow best practice: Don't ignore arbitrary warnings.
Modified:
subversion/trunk/tools/dist/release.py
Modified: subversion/trunk/tools/dist/release.py
URL: http://svn.apache.org/viewvc/subversion/trunk/tools/dist/release.py?rev=1800547&r1=1800546&r2=1800547&view=diff
==============================================================================
--- subversion/trunk/tools/dist/release.py (original)
+++ subversion/trunk/tools/dist/release.py Sun Jul 2 05:59:04 2017
@@ -875,8 +875,14 @@ def get_siginfo(args, quiet=False):
stderr=subprocess.STDOUT,
)
- gpg_output = "\n".join([ l for l in gpg_output.splitlines()
- if l[0:7] != 'Warning' ])
+ # This code was added in r934990, but there was no comment (nor log
+ # message text) explaining its purpose. I've commented it out since
+ # ignoring arbitrary warnings in a verification codepath is Bad. If
+ # you run into warnings on your machine, feel free to uncomment it,
+ # but when you do so please make it match specific warnings only.
+ #
+ #gpg_output = "\n".join([ l for l in gpg_output.splitlines()
+ # if l[0:7] != 'Warning' ])
match = fp_pattern.match(gpg_output)
format_expandos = dict(