You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "khmarbaise (via GitHub)" <gi...@apache.org> on 2023/04/15 17:42:41 UTC
[GitHub] [maven] khmarbaise opened a new pull request, #1091: [MNG-7451] - Remove public modifier from test methods / test classes
khmarbaise opened a new pull request, #1091:
URL: https://github.com/apache/maven/pull/1091
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`,
where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue.
- [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`.
Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] khmarbaise commented on pull request #1091: [MNG-7451] - Remove public modifier from test methods / test classes
Posted by "khmarbaise (via GitHub)" <gi...@apache.org>.
khmarbaise commented on PR #1091:
URL: https://github.com/apache/maven/pull/1091#issuecomment-1510290454
Since JUnit Jupiter it's not neccessary to have public test classes and test methods...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] olamy commented on pull request #1091: [MNG-7451] - Remove public modifier from test methods / test classes
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on PR #1091:
URL: https://github.com/apache/maven/pull/1091#issuecomment-1510314859
> Since JUnit Jupiter it's not neccessary to have public test classes and test methods...
ah right. thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] olamy commented on pull request #1091: [MNG-7451] - Remove public modifier from test methods / test classes
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on PR #1091:
URL: https://github.com/apache/maven/pull/1091#issuecomment-1510097973
what is the reason of this? I cannot find any justification of what brings those changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] khmarbaise commented on pull request #1091: [MNG-7451] - Remove public modifier from test methods / test classes
Posted by "khmarbaise (via GitHub)" <gi...@apache.org>.
khmarbaise commented on PR #1091:
URL: https://github.com/apache/maven/pull/1091#issuecomment-1510359805
> I hope that JavaDocs for test classes are not generated. When we have no public items, JavaDocs will produce error.
Ah good hint...based on the current setup https://maven.apache.org/ref/4.0.0-alpha-5/apidocs/index.html There seemed to be no javadoc for test classes at all because we don't have a "reporting" area in the modules anymore.
Also tried to run the site generation including the `reporting` profile without any issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] asfgit closed pull request #1091: [MNG-7451] - Remove public modifier from test methods / test classes
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #1091: [MNG-7451] - Remove public modifier from test methods / test classes
URL: https://github.com/apache/maven/pull/1091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org