You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/02/17 18:49:57 UTC
[GitHub] [tvm] areusch opened a new pull request #10292: Run cpplint in quiet mode
areusch opened a new pull request #10292:
URL: https://github.com/apache/tvm/pull/10292
Removes lots of
```
Done processing ...
```
spam from cpplint logs.
cc @driazati
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] github-actions[bot] commented on pull request #10292: Run cpplint in quiet mode
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10292:
URL: https://github.com/apache/tvm/pull/10292#issuecomment-1081174101
It has been a while since this PR was updated, @tqchen @driazati @driazati please leave a review or address the outstanding comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #10292: Run cpplint in quiet mode
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #10292:
URL: https://github.com/apache/tvm/pull/10292#issuecomment-1067311266
:/ i think maybe the rust build is busted when dlpack is updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] github-actions[bot] commented on pull request #10292: Run cpplint in quiet mode
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10292:
URL: https://github.com/apache/tvm/pull/10292#issuecomment-1074441736
It has been a while since this PR was updated, @tqchen @driazati @driazati please leave a review or address the outstanding comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #10292: Run cpplint in quiet mode
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #10292:
URL: https://github.com/apache/tvm/pull/10292#issuecomment-1043309499
also cc @tqchen due to related dmlc-core change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a change in pull request #10292: Run cpplint in quiet mode
Posted by GitBox <gi...@apache.org>.
driazati commented on a change in pull request #10292:
URL: https://github.com/apache/tvm/pull/10292#discussion_r809380239
##########
File path: tests/lint/cpplint.sh
##########
@@ -17,8 +17,9 @@
# under the License.
-python3 3rdparty/dmlc-core/scripts/lint.py vta cpp vta/include vta/src
-python3 3rdparty/dmlc-core/scripts/lint.py tvm cpp \
+echo "Running 2 cpplints (VTA and TVM)..."
+python3 3rdparty/dmlc-core/scripts/lint.py --quiet vta cpp vta/include vta/src
+python3 3rdparty/dmlc-core/scripts/lint.py --quiet tvm cpp \
Review comment:
These take kind of a while so it'd be nice to mention them separately
```suggestion
echo "Running VTA cpplint"
python3 3rdparty/dmlc-core/scripts/lint.py --quiet vta cpp vta/include vta/src
echo "Running TVM cpplint"
python3 3rdparty/dmlc-core/scripts/lint.py --quiet tvm cpp \
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org