You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Reranko05 (via GitHub)" <gi...@apache.org> on 2026/07/25 12:20:28 UTC
[PR] GH-50637: [C++] Register bundled Abseil libraries in `build_absl()` [arrow]
Reranko05 opened a new pull request, #50638:
URL: https://github.com/apache/arrow/pull/50638
### What changes are included?
Move the registration of bundled Abseil static libraries from `build_protobuf()` to `build_absl()`.
Since the Abseil targets are defined in `build_absl()`, registering them there keeps the bundled dependency registration with the component that provides them instead of coupling it to the Protobuf build logic.
### Are these changes tested?
- Configured Arrow successfully with CMake.
- Built Arrow successfully with the default configuration.
- CI will verify the change across supported platforms, including the Windows configuration where this issue was originally observed.
### Are there any user-facing changes?
No. This is an internal CMake/build system change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50637: [C++] Register bundled Abseil libraries in `build_absl()` [arrow]
Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on PR #50638:
URL: https://github.com/apache/arrow/pull/50638#issuecomment-5078794781
All triggered CI checks are green. If someone could trigger `Windows JNI` workflow, it would help verify this fix against the original issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50637: [C++] Register bundled Abseil libraries in `build_absl()` [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #50638:
URL: https://github.com/apache/arrow/pull/50638#issuecomment-5088290732
https://github.com/apache/arrow/pull/50650 may reproduce this problem: https://github.com/apache/arrow/actions/runs/30229829560/job/89866480718?pr=50650#step:20:5572
```text
/opt/rh/gcc-toolset-14/root/usr/libexec/gcc/x86_64-redhat-linux/14/ld: /usr/lib64/libarrow_bundled_dependencies.a(futex_waiter.cc.o): in function `absl::lts_20250127::synchronization_internal::FutexWaiter::WaitUntil(std::atomic<int>*, int, absl::lts_20250127::synchronization_internal::KernelTimeout) [clone .localalias]':
(.text+0x3b): undefined reference to `absl::lts_20250127::synchronization_internal::KernelTimeout::MakeAbsTimespec() const'
/opt/rh/gcc-toolset-14/root/usr/libexec/gcc/x86_64-redhat-linux/14/ld: (.text+0x91): undefined reference to `absl::lts_20250127::synchronization_internal::KernelTimeout::MakeRelativeTimespec() const'
```
I'll try this in #50650.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50637: [C++] Register bundled Abseil libraries in `build_absl()` [arrow]
Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on PR #50638:
URL: https://github.com/apache/arrow/pull/50638#issuecomment-5103437550
@kou Since this implementation is being done in #50650, I'm closing this PR. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50637: [C++] Register bundled Abseil libraries in `build_absl()` [arrow]
Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on PR #50638:
URL: https://github.com/apache/arrow/pull/50638#issuecomment-5081787263
Thanks @tadeja
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50637: [C++] Register bundled Abseil libraries in `build_absl()` [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #50638:
URL: https://github.com/apache/arrow/pull/50638#discussion_r3653811796
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
Review Comment:
We should not remove this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50637: [C++] Register bundled Abseil libraries in `build_absl()` [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #50638:
URL: https://github.com/apache/arrow/pull/50638#discussion_r3653811796
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
Review Comment:
We should not remove this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50637: [C++] Register bundled Abseil libraries in `build_absl()` [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #50638:
URL: https://github.com/apache/arrow/pull/50638#discussion_r3653814936
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
Review Comment:
We should not remove this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50637: [C++] Register bundled Abseil libraries in `build_absl()` [arrow]
Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on code in PR #50638:
URL: https://github.com/apache/arrow/pull/50638#discussion_r3655091485
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
Review Comment:
I have restored `list(POP_BACK CMAKE_MESSAGE_INDENT)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50637: [C++] Register bundled Abseil libraries in `build_absl()` [arrow]
Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on PR #50638:
URL: https://github.com/apache/arrow/pull/50638#issuecomment-5088378752
> I'll try this in https://github.com/apache/arrow/pull/50650.
Thanks! I will wait for the results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50637: [C++] Register bundled Abseil libraries in `build_absl()` [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #50638:
URL: https://github.com/apache/arrow/pull/50638#discussion_r3653816526
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
Review Comment:
We should not remove `list(POP_BACK CMAKE_MESSAGE_INDENT)`.
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
Review Comment:
We should not remove this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-50637: [C++] Register bundled Abseil libraries in `build_absl()` [arrow]
Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 closed pull request #50638: GH-50637: [C++] Register bundled Abseil libraries in `build_absl()`
URL: https://github.com/apache/arrow/pull/50638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org