You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@twopensource.com> on 2014/11/07 00:40:41 UTC

Review Request 27710: Remove stracktrace redirection.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27710/
-----------------------------------------------------------

Review request for Aurora, Joshua Cohen, Joe Smith, and Bill Farner.


Bugs: AURORA-896
    https://issues.apache.org/jira/browse/AURORA-896


Repository: aurora


Description
-------

Remove stracktrace redirection.


Diffs
-----

  src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 
  src/main/python/apache/aurora/client/cli/standalone_client.py b7c8de66d6e4664b536911f826e36a984e8d0fef 
  src/test/python/apache/aurora/client/cli/test_create.py 31fa56f5edcfc97903725ab27ccc12c6a8f39ffc 

Diff: https://reviews.apache.org/r/27710/diff/


Testing
-------

Example raising exception
````
vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job killall devcluster/www-data/test/cron_hello_world
Fatal error running command:
Traceback (most recent call last):
  File "/usr/local/bin/aurora2/apache/aurora/client/cli/__init__.py", line 394, in _execute
    result = noun.execute(context)
  File "/usr/local/bin/aurora2/apache/aurora/client/cli/__init__.py", line 481, in execute
    return self.verbs[context.options.verb].execute(context)
  File "/usr/local/bin/aurora2/apache/aurora/client/cli/jobs.py", line 393, in execute
    raise ValueError()
ValueError
````


Thanks,

Zameer Manji


Re: Review Request 27710: Remove stracktrace redirection.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27710/#review60273
-----------------------------------------------------------

Ship it!


Master (5250a94) is green with this patch.
  ./build-support/jenkins/build.sh

- Aurora ReviewBot


On Nov. 6, 2014, 11:40 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27710/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2014, 11:40 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Joe Smith, and Bill Farner.
> 
> 
> Bugs: AURORA-896
>     https://issues.apache.org/jira/browse/AURORA-896
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove stracktrace redirection.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 
>   src/main/python/apache/aurora/client/cli/standalone_client.py b7c8de66d6e4664b536911f826e36a984e8d0fef 
>   src/test/python/apache/aurora/client/cli/test_create.py 31fa56f5edcfc97903725ab27ccc12c6a8f39ffc 
> 
> Diff: https://reviews.apache.org/r/27710/diff/
> 
> 
> Testing
> -------
> 
> Example raising exception
> ````
> vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job killall devcluster/www-data/test/cron_hello_world
> Fatal error running command:
> Traceback (most recent call last):
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/__init__.py", line 394, in _execute
>     result = noun.execute(context)
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/__init__.py", line 481, in execute
>     return self.verbs[context.options.verb].execute(context)
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/jobs.py", line 393, in execute
>     raise ValueError()
> ValueError
> ````
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Re: Review Request 27710: Remove stracktrace redirection.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27710/#review60727
-----------------------------------------------------------

Ship it!


This is now on master:
    $ git log -1 origin/master --abbrev-commit
    commit 5b3b751
    Author: Zameer Manji <zm...@twopensource.com>
    Date:   Mon Nov 10 17:10:41 2014 -0800

        Remove stracktrace redirection.
        
        Bugs closed: AURORA-896
        
        Reviewed at https://reviews.apache.org/r/27710/

- Bill Farner


On Nov. 10, 2014, 11:36 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27710/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2014, 11:36 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Joe Smith, and Bill Farner.
> 
> 
> Bugs: AURORA-896
>     https://issues.apache.org/jira/browse/AURORA-896
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove stracktrace redirection.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 
>   src/main/python/apache/aurora/client/cli/standalone_client.py b7c8de66d6e4664b536911f826e36a984e8d0fef 
>   src/test/python/apache/aurora/client/cli/test_create.py 31fa56f5edcfc97903725ab27ccc12c6a8f39ffc 
> 
> Diff: https://reviews.apache.org/r/27710/diff/
> 
> 
> Testing
> -------
> 
> Example raising exception
> ````
> vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job killall devcluster/www-data/test/cron_hello_world
> Fatal error running command:
> Traceback (most recent call last):
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/__init__.py", line 394, in _execute
>     result = noun.execute(context)
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/__init__.py", line 481, in execute
>     return self.verbs[context.options.verb].execute(context)
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/jobs.py", line 393, in execute
>     raise ValueError()
> ValueError
> ````
> 
> Clean vagrant image and running
> ````
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
> ````
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Re: Review Request 27710: Remove stracktrace redirection.

Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27710/
-----------------------------------------------------------

(Updated Nov. 10, 2014, 3:36 p.m.)


Review request for Aurora, Joshua Cohen, Joe Smith, and Bill Farner.


Bugs: AURORA-896
    https://issues.apache.org/jira/browse/AURORA-896


Repository: aurora


Description
-------

Remove stracktrace redirection.


Diffs
-----

  src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 
  src/main/python/apache/aurora/client/cli/standalone_client.py b7c8de66d6e4664b536911f826e36a984e8d0fef 
  src/test/python/apache/aurora/client/cli/test_create.py 31fa56f5edcfc97903725ab27ccc12c6a8f39ffc 

Diff: https://reviews.apache.org/r/27710/diff/


Testing (updated)
-------

Example raising exception
````
vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job killall devcluster/www-data/test/cron_hello_world
Fatal error running command:
Traceback (most recent call last):
  File "/usr/local/bin/aurora2/apache/aurora/client/cli/__init__.py", line 394, in _execute
    result = noun.execute(context)
  File "/usr/local/bin/aurora2/apache/aurora/client/cli/__init__.py", line 481, in execute
    return self.verbs[context.options.verb].execute(context)
  File "/usr/local/bin/aurora2/apache/aurora/client/cli/jobs.py", line 393, in execute
    raise ValueError()
ValueError
````

Clean vagrant image and running
````
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
````


Thanks,

Zameer Manji


Re: Review Request 27710: Remove stracktrace redirection.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27710/#review60404
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On Nov. 6, 2014, 11:40 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27710/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2014, 11:40 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Joe Smith, and Bill Farner.
> 
> 
> Bugs: AURORA-896
>     https://issues.apache.org/jira/browse/AURORA-896
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove stracktrace redirection.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 
>   src/main/python/apache/aurora/client/cli/standalone_client.py b7c8de66d6e4664b536911f826e36a984e8d0fef 
>   src/test/python/apache/aurora/client/cli/test_create.py 31fa56f5edcfc97903725ab27ccc12c6a8f39ffc 
> 
> Diff: https://reviews.apache.org/r/27710/diff/
> 
> 
> Testing
> -------
> 
> Example raising exception
> ````
> vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job killall devcluster/www-data/test/cron_hello_world
> Fatal error running command:
> Traceback (most recent call last):
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/__init__.py", line 394, in _execute
>     result = noun.execute(context)
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/__init__.py", line 481, in execute
>     return self.verbs[context.options.verb].execute(context)
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/jobs.py", line 393, in execute
>     raise ValueError()
> ValueError
> ````
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Re: Review Request 27710: Remove stracktrace redirection.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27710/#review60469
-----------------------------------------------------------


Master (54b0262) is red with this patch.
  ./build-support/jenkins/build.sh

**** Failed to install psutil-2.1.3. stderr:
unable to execute gcc-4.2: No such file or directory
error: command 'gcc-4.2' failed with exit status 1

Build operating on top level addresses: set([BuildFileAddress(/Users/bill/code/aurora2/src/test/python/BUILD, all)])
Problem executing PythonBuilder for targets OrderedSet([PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/admin/BUILD, host_maintenance)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/BUILD, api)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/api/BUILD, api)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/api/BUILD, restarter)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/api/BUILD, instance_watcher)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/api/BUILD, scheduler_client)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/common/auth/BUILD, auth)), PythonThriftLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift)), PythonLib
 rary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/common/BUILD, cluster)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/common/BUILD, transport)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/api/BUILD, scheduler_mux)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/api/BUILD, error_handling_thread)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/api/BUILD, task_util)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/BUILD, base)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/common/BUILD, http_signaler)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/api/BUILD, updater_util)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/pytho
 n/apache/aurora/client/api/BUILD, sla)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/common/BUILD, common)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/common/BUILD, aurora_job_key)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/common/BUILD, cluster_option)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/common/BUILD, clusters)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/common/BUILD, shellify)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-packaged)), PythonThriftLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-test)), PythonThriftLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/thrift/org/apache/aurora/gen/BUILD, py-thrift-storage)), PythonLibr
 ary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/api/BUILD, updater)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/api/BUILD, job_monitor)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/api/BUILD, quota_check)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/admin/BUILD, host_maintenance)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/admin/BUILD, util)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/admin/BUILD, admin_util)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/BUILD, binding_helper)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/BUILD, binding_helper)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/auro
 ra/config/BUILD, config)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/config/schema/BUILD, schema)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/thermos/config/BUILD, schema)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/thermos/common/BUILD, planner)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/BUILD, config)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/BUILD, config)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/api/BUILD, api)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/api/BUILD, disambiguator)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/api/BUILD, disambiguator)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/
 python/apache/aurora/client/api/BUILD, instance_watcher)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/api/BUILD, job_monitor)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/BUILD, fake_scheduler_proxy)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/api/BUILD, mux)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/api/BUILD, quota_check)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/api/BUILD, restarter)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/api/BUILD, scheduler_client)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/api/BUILD, sla)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/api/BUILD, updater)), PythonTests(
 BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/api/BUILD, updater_util)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/cli/BUILD, api)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/cli/BUILD, util)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/cli/BUILD, cli)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/api/BUILD, command_runner)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/config/BUILD, schema)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/hooks/BUILD, hooks)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/BUILD, factory)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/BUILD, o
 ptions)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/thermos/common/BUILD, options)), PythonThriftLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/thrift/org/apache/thermos/BUILD, py-thrift)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/cli/BUILD, client_lib)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/cli/BUILD, bridge)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/bin/BUILD, aurora_admin_lib)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/commands/BUILD, admin)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/commands/BUILD, help)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/commands/BUILD, maintenance)), PythonLibrary(BuildFileAddress(/Users/bill/
 code/aurora2/src/main/python/apache/aurora/client/bin/BUILD, aurora_client_lib)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/commands/BUILD, all)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/commands/BUILD, core)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/commands/BUILD, run)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/client/commands/BUILD, ssh)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/commands/BUILD, util)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/cli/BUILD, bridge)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/cli/BUILD, command_hooks)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/cli/BUILD, 
 cron)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/cli/BUILD, help)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/cli/BUILD, inspect)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/cli/BUILD, job)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/cli/BUILD, config)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/cli/BUILD, logging)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/cli/BUILD, plugins)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/cli/BUILD, quota)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/cli/BUILD, sla)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/cli/BUIL
 D, task)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/cli/BUILD, supdate)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/cli/BUILD, update)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/commands/BUILD, admin)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/commands/BUILD, core)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/commands/BUILD, hooks)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/commands/BUILD, maintenance)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/commands/BUILD, run)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/commands/BUILD, ssh)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/p
 ython/apache/aurora/client/hooks/BUILD, hooked_api)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/client/hooks/BUILD, non_hooked_api)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/common/BUILD, test_aurora_job_key)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/common/BUILD, test_cluster)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/common/BUILD, test_clusters)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/common/BUILD, test_cluster_option)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/common/BUILD, test_http_signaler)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/common/BUILD, test_shellify)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/common/BUILD, test_transport)),
  PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/config/BUILD, test_base)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/config/BUILD, test_constraint_parsing)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/config/BUILD, test_loader)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/config/BUILD, test_thrift)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/executor/BUILD, executor_base)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/executor/BUILD, executor_base)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/executor/BUILD, executor_detector)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/executor/BUILD, executor_detector)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/
 src/test/python/apache/aurora/executor/BUILD, executor_vars)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/executor/BUILD, executor_vars)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/executor/BUILD, status_manager)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/executor/BUILD, status_manager)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/executor/common/BUILD, status_checker)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/executor/BUILD, thermos_task_runner)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/executor/common/BUILD, sandbox)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/executor/BUILD, thermos_task_runner)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/the
 rmos/common/BUILD, common)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/thermos/common/BUILD, ckpt)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/thermos/common/BUILD, path)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/thermos/core/BUILD, core)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/thermos/core/BUILD, inspector)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/thermos/core/BUILD, muxer)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/thermos/core/BUILD, runner)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/thermos/core/BUILD, helper)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/thermos/core/BUILD, process)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/thermos/config/B
 UILD, config)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/thermos/monitoring/BUILD, monitor)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/executor/common/BUILD, task_info)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/executor/common/BUILD, task_runner)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/executor/BUILD, thermos_statuses)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/executor/common/BUILD, announcer)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/executor/common/BUILD, announcer)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/executor/common/BUILD, directory_sandbox)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/executor/common/BUILD, executor_timeout)), 
 PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/executor/common/BUILD, executor_timeout)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/executor/common/BUILD, health_checker)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/executor/common/BUILD, fixtures)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/executor/common/BUILD, health_checker)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/executor/common/BUILD, status_checker)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/executor/common/BUILD, task_info)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/executor/BUILD, gc_executor)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/executor/BUILD, gc_executor)), PythonLibrary(Buil
 dFileAddress(/Users/bill/code/aurora2/src/main/python/apache/thermos/monitoring/BUILD, detector)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/thermos/monitoring/BUILD, garbage)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/aurora/executor/BUILD, thermos_executor)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/executor/BUILD, aurora_executor)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/aurora/executor/common/BUILD, kill_manager)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/thermos/bin/BUILD, test_thermos)), PythonBinary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/thermos/bin/BUILD, thermos)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/thermos/monitoring/BUILD, monitoring)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apach
 e/thermos/monitoring/BUILD, disk)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/thermos/monitoring/BUILD, process)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/thermos/monitoring/BUILD, resource)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/thermos/monitoring/BUILD, process_collector_psutil)), PythonLibrary(BuildFileAddress(/Users/bill/code/aurora2/src/main/python/apache/thermos/testing/BUILD, runner)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/thermos/common/BUILD, test_pathspec)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/thermos/common/BUILD, test_planner)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/thermos/common/BUILD, test_task_planner)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/thermos/config/BUILD, test_schema)), PythonTests(BuildF
 ileAddress(/Users/bill/code/aurora2/src/test/python/apache/thermos/core/BUILD, test_process)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/thermos/core/BUILD, test_ephemerals)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/thermos/core/BUILD, test_failing_runner)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/thermos/core/BUILD, test_failure_limit)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/thermos/core/BUILD, test_finalization)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/thermos/core/BUILD, test_helper)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/thermos/core/BUILD, test_runner_integration)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/thermos/core/BUILD, test_angry)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/therm
 os/core/BUILD, test_staged_kill)), PythonTests(BuildFileAddress(/Users/bill/code/aurora2/src/test/python/apache/thermos/monitoring/BUILD, test_disk))]): Traceback (most recent call last):
  File "/Users/bill/code/aurora2/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/commands/build.py", line 130, in _python_build
    debug=self._verbose)
  File "/Users/bill/code/aurora2/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/python_builder.py", line 43, in build
    debug=debug).run()
  File "/Users/bill/code/aurora2/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py", line 88, in run
    rv = self._run_tests([target], stdout, stderr)
  File "/Users/bill/code/aurora2/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py", line 316, in _run_tests
    with self._test_runner(targets, stdout, stderr) as (pex, test_args):
  File "/opt/local/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/contextlib.py", line 17, in __enter__
    return self.gen.next()
  File "/Users/bill/code/aurora2/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/test_builder.py", line 295, in _test_runner
    builder = chroot.dump()
  File "/Users/bill/code/aurora2/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/python_chroot.py", line 191, in dump
    conn_timeout=self._conn_timeout)
  File "/Users/bill/code/aurora2/build-support/pants.venv/lib/python2.7/site-packages/pants/backend/python/resolver.py", line 100, in resolve_multi
    platform=platform)
  File "/Users/bill/code/aurora2/build-support/pants.venv/lib/python2.7/site-packages/pex/resolver.py", line 110, in resolve
    new_requirements.update(requires(highest_package, requirement))
  File "/Users/bill/code/aurora2/build-support/pants.venv/lib/python2.7/site-packages/pex/resolver.py", line 84, in requires
    raise Untranslateable('Package %s is not translateable.' % package)
Untranslateable: Package SourcePackage(u'https://pypi.python.org/packages/source/p/psutil/psutil-2.1.3.tar.gz#md5=015a013c46bb9bc30b5c344f26dea0d3') is not translateable.


Usage: 
  pants build (options) [spec] (build args)
  pants build (options) [spec]... -- (build args)

Options:
  --version             show program's version number and exit
  --no-pantsrc          Specifies that pantsrc files should be ignored.
  --log-exit            Log an exit message on success or failure.
  -t CONN_TIMEOUT, --timeout=CONN_TIMEOUT
                        Number of seconds to wait for http connections.
  -i INTERPRETERS, --interpreter=INTERPRETERS
                        Constrain what Python interpreters to use.  Uses
                        Requirement format from pkg_resources, e.g.
                        'CPython>=2.6,<3' or 'PyPy'. By default, no
                        constraints are used.  Multiple constraints may be
                        added.  They will be ORed together.
  -v, --verbose         Show verbose output.
  -f, --fast            Run tests in a single chroot.

Builds the specified Python target(s). Use ./pants goal for JVM and other
targets.


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Nov. 6, 2014, 11:40 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27710/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2014, 11:40 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Joe Smith, and Bill Farner.
> 
> 
> Bugs: AURORA-896
>     https://issues.apache.org/jira/browse/AURORA-896
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove stracktrace redirection.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 
>   src/main/python/apache/aurora/client/cli/standalone_client.py b7c8de66d6e4664b536911f826e36a984e8d0fef 
>   src/test/python/apache/aurora/client/cli/test_create.py 31fa56f5edcfc97903725ab27ccc12c6a8f39ffc 
> 
> Diff: https://reviews.apache.org/r/27710/diff/
> 
> 
> Testing
> -------
> 
> Example raising exception
> ````
> vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job killall devcluster/www-data/test/cron_hello_world
> Fatal error running command:
> Traceback (most recent call last):
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/__init__.py", line 394, in _execute
>     result = noun.execute(context)
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/__init__.py", line 481, in execute
>     return self.verbs[context.options.verb].execute(context)
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/jobs.py", line 393, in execute
>     raise ValueError()
> ValueError
> ````
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Re: Review Request 27710: Remove stracktrace redirection.

Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27710/#review60454
-----------------------------------------------------------

Ship it!


Ship It!

- Joe Smith


On Nov. 6, 2014, 3:40 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27710/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2014, 3:40 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Joe Smith, and Bill Farner.
> 
> 
> Bugs: AURORA-896
>     https://issues.apache.org/jira/browse/AURORA-896
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove stracktrace redirection.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 
>   src/main/python/apache/aurora/client/cli/standalone_client.py b7c8de66d6e4664b536911f826e36a984e8d0fef 
>   src/test/python/apache/aurora/client/cli/test_create.py 31fa56f5edcfc97903725ab27ccc12c6a8f39ffc 
> 
> Diff: https://reviews.apache.org/r/27710/diff/
> 
> 
> Testing
> -------
> 
> Example raising exception
> ````
> vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job killall devcluster/www-data/test/cron_hello_world
> Fatal error running command:
> Traceback (most recent call last):
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/__init__.py", line 394, in _execute
>     result = noun.execute(context)
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/__init__.py", line 481, in execute
>     return self.verbs[context.options.verb].execute(context)
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/jobs.py", line 393, in execute
>     raise ValueError()
> ValueError
> ````
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Re: Review Request 27710: Remove stracktrace redirection.

Posted by Zameer Manji <zm...@twopensource.com>.

> On Nov. 10, 2014, 10:49 a.m., Zameer Manji wrote:
> > Bill, since you are the only committer and everyone has given a shipit can you please commit this change?
> 
> Bill Farner wrote:
>     Before i commit, can you run and confirm passing end-to-end tests?
>         ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>         ./src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh

Done.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27710/#review60637
-----------------------------------------------------------


On Nov. 10, 2014, 3:36 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27710/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2014, 3:36 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Joe Smith, and Bill Farner.
> 
> 
> Bugs: AURORA-896
>     https://issues.apache.org/jira/browse/AURORA-896
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove stracktrace redirection.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 
>   src/main/python/apache/aurora/client/cli/standalone_client.py b7c8de66d6e4664b536911f826e36a984e8d0fef 
>   src/test/python/apache/aurora/client/cli/test_create.py 31fa56f5edcfc97903725ab27ccc12c6a8f39ffc 
> 
> Diff: https://reviews.apache.org/r/27710/diff/
> 
> 
> Testing
> -------
> 
> Example raising exception
> ````
> vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job killall devcluster/www-data/test/cron_hello_world
> Fatal error running command:
> Traceback (most recent call last):
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/__init__.py", line 394, in _execute
>     result = noun.execute(context)
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/__init__.py", line 481, in execute
>     return self.verbs[context.options.verb].execute(context)
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/jobs.py", line 393, in execute
>     raise ValueError()
> ValueError
> ````
> 
> Clean vagrant image and running
> ````
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
> ````
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Re: Review Request 27710: Remove stracktrace redirection.

Posted by Bill Farner <wf...@apache.org>.

> On Nov. 10, 2014, 6:49 p.m., Zameer Manji wrote:
> > Bill, since you are the only committer and everyone has given a shipit can you please commit this change?

Before i commit, can you run and confirm passing end-to-end tests?
    ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
    ./src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27710/#review60637
-----------------------------------------------------------


On Nov. 6, 2014, 11:40 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27710/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2014, 11:40 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Joe Smith, and Bill Farner.
> 
> 
> Bugs: AURORA-896
>     https://issues.apache.org/jira/browse/AURORA-896
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove stracktrace redirection.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 
>   src/main/python/apache/aurora/client/cli/standalone_client.py b7c8de66d6e4664b536911f826e36a984e8d0fef 
>   src/test/python/apache/aurora/client/cli/test_create.py 31fa56f5edcfc97903725ab27ccc12c6a8f39ffc 
> 
> Diff: https://reviews.apache.org/r/27710/diff/
> 
> 
> Testing
> -------
> 
> Example raising exception
> ````
> vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job killall devcluster/www-data/test/cron_hello_world
> Fatal error running command:
> Traceback (most recent call last):
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/__init__.py", line 394, in _execute
>     result = noun.execute(context)
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/__init__.py", line 481, in execute
>     return self.verbs[context.options.verb].execute(context)
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/jobs.py", line 393, in execute
>     raise ValueError()
> ValueError
> ````
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Re: Review Request 27710: Remove stracktrace redirection.

Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27710/#review60637
-----------------------------------------------------------


Bill, since you are the only committer and everyone has given a shipit can you please commit this change?

- Zameer Manji


On Nov. 6, 2014, 3:40 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27710/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2014, 3:40 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Joe Smith, and Bill Farner.
> 
> 
> Bugs: AURORA-896
>     https://issues.apache.org/jira/browse/AURORA-896
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove stracktrace redirection.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 
>   src/main/python/apache/aurora/client/cli/standalone_client.py b7c8de66d6e4664b536911f826e36a984e8d0fef 
>   src/test/python/apache/aurora/client/cli/test_create.py 31fa56f5edcfc97903725ab27ccc12c6a8f39ffc 
> 
> Diff: https://reviews.apache.org/r/27710/diff/
> 
> 
> Testing
> -------
> 
> Example raising exception
> ````
> vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job killall devcluster/www-data/test/cron_hello_world
> Fatal error running command:
> Traceback (most recent call last):
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/__init__.py", line 394, in _execute
>     result = noun.execute(context)
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/__init__.py", line 481, in execute
>     return self.verbs[context.options.verb].execute(context)
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/jobs.py", line 393, in execute
>     raise ValueError()
> ValueError
> ````
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Re: Review Request 27710: Remove stracktrace redirection.

Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27710/#review60407
-----------------------------------------------------------

Ship it!


Ship It!

- Joshua Cohen


On Nov. 6, 2014, 11:40 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27710/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2014, 11:40 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Joe Smith, and Bill Farner.
> 
> 
> Bugs: AURORA-896
>     https://issues.apache.org/jira/browse/AURORA-896
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove stracktrace redirection.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 
>   src/main/python/apache/aurora/client/cli/standalone_client.py b7c8de66d6e4664b536911f826e36a984e8d0fef 
>   src/test/python/apache/aurora/client/cli/test_create.py 31fa56f5edcfc97903725ab27ccc12c6a8f39ffc 
> 
> Diff: https://reviews.apache.org/r/27710/diff/
> 
> 
> Testing
> -------
> 
> Example raising exception
> ````
> vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job killall devcluster/www-data/test/cron_hello_world
> Fatal error running command:
> Traceback (most recent call last):
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/__init__.py", line 394, in _execute
>     result = noun.execute(context)
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/__init__.py", line 481, in execute
>     return self.verbs[context.options.verb].execute(context)
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/jobs.py", line 393, in execute
>     raise ValueError()
> ValueError
> ````
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Re: Review Request 27710: Remove stracktrace redirection.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27710/#review60464
-----------------------------------------------------------


@ReviewBot retry

(don't mind me, trying something out)

- Bill Farner


On Nov. 6, 2014, 11:40 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27710/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2014, 11:40 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Joe Smith, and Bill Farner.
> 
> 
> Bugs: AURORA-896
>     https://issues.apache.org/jira/browse/AURORA-896
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove stracktrace redirection.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 
>   src/main/python/apache/aurora/client/cli/standalone_client.py b7c8de66d6e4664b536911f826e36a984e8d0fef 
>   src/test/python/apache/aurora/client/cli/test_create.py 31fa56f5edcfc97903725ab27ccc12c6a8f39ffc 
> 
> Diff: https://reviews.apache.org/r/27710/diff/
> 
> 
> Testing
> -------
> 
> Example raising exception
> ````
> vagrant@vagrant-ubuntu-trusty-64:~$ aurora2 job killall devcluster/www-data/test/cron_hello_world
> Fatal error running command:
> Traceback (most recent call last):
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/__init__.py", line 394, in _execute
>     result = noun.execute(context)
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/__init__.py", line 481, in execute
>     return self.verbs[context.options.verb].execute(context)
>   File "/usr/local/bin/aurora2/apache/aurora/client/cli/jobs.py", line 393, in execute
>     raise ValueError()
> ValueError
> ````
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>