You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2017/10/17 10:04:18 UTC
Review Request 63068: RANGER-1842 - Don't catch Throwables in the
test code
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63068/
-----------------------------------------------------------
Review request for ranger.
Bugs: RANGER-1842
https://issues.apache.org/jira/browse/RANGER-1842
Repository: ranger
Description
-------
In a couple of the tests, we are catching Throwables. This means that the Assert.fail() conditions inside the try statement are ineffective.
Diffs
-----
kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerMasterKeyTest.java cac22502
storm-agent/src/test/java/org/apache/ranger/authorization/storm/StormRangerAuthorizerTest.java 53173078
Diff: https://reviews.apache.org/r/63068/diff/1/
Testing
-------
Thanks,
Colm O hEigeartaigh
Re: Review Request 63068: RANGER-1842 - Don't catch Throwables in the
test code
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63068/#review188342
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Oct. 17, 2017, 10:04 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63068/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 10:04 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1842
> https://issues.apache.org/jira/browse/RANGER-1842
>
>
> Repository: ranger
>
>
> Description
> -------
>
> In a couple of the tests, we are catching Throwables. This means that the Assert.fail() conditions inside the try statement are ineffective.
>
>
> Diffs
> -----
>
> kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerMasterKeyTest.java cac22502
> storm-agent/src/test/java/org/apache/ranger/authorization/storm/StormRangerAuthorizerTest.java 53173078
>
>
> Diff: https://reviews.apache.org/r/63068/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>
Re: Review Request 63068: RANGER-1842 - Don't catch Throwables in the
test code
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63068/#review188675
-----------------------------------------------------------
Ship it!
Ship It!
- pengjianhua
On 十月 17, 2017, 10:04 a.m., Colm O hEigeartaigh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63068/
> -----------------------------------------------------------
>
> (Updated 十月 17, 2017, 10:04 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-1842
> https://issues.apache.org/jira/browse/RANGER-1842
>
>
> Repository: ranger
>
>
> Description
> -------
>
> In a couple of the tests, we are catching Throwables. This means that the Assert.fail() conditions inside the try statement are ineffective.
>
>
> Diffs
> -----
>
> kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/RangerMasterKeyTest.java cac22502
> storm-agent/src/test/java/org/apache/ranger/authorization/storm/StormRangerAuthorizerTest.java 53173078
>
>
> Diff: https://reviews.apache.org/r/63068/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colm O hEigeartaigh
>
>