[GitHub] [beam] mattrudary commented on pull request #15036: [BEAM-12435] Generalize S3FileSystem to support multiple URI schemes.

[GitBox <gi...@apache.org>]

mattrudary commented on pull request #15036:
URL: https://github.com/apache/beam/pull/15036#issuecomment-877629364


   > Thanks for contribution one more time, I believe it should be useful for users! And sorry for delay with review.
   > 
   > It looks fine for me in general but I'm a bit concerned about public user API and previous functionality. Do you expect any breakage or changes there?
   
   I don't expect any breakage or changes. The s3 URI scheme is automatically registered using the S3Options, which should lead to identical behavior.
   
   The only potential issue is the serial version UID of the S3ResourceId, which might cause problems with people trying to upgrade pipelines in place. I tried computing the serial version ID on a few JDKs that I could find and that gave me the ID that I set explicitly. It's a fairly simple class so it makes sense that its serial version would be the same on all JDKs but I can't promise that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org