[GitHub] [spark] cxzl25 commented on a change in pull request #28383: [SPARK-31590][SQL] The filter used by Metadata-only queries should filter out all the unevaluable expr

[GitBox <gi...@apache.org>]

cxzl25 commented on a change in pull request #28383:
URL: https://github.com/apache/spark/pull/28383#discussion_r418869108



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/OptimizeMetadataOnlyQuerySuite.scala
##########
@@ -103,6 +103,20 @@ class OptimizeMetadataOnlyQuerySuite extends QueryTest with SharedSparkSession {
     "select partcol2, min(partcol1) from srcpart where partcol1 = 0 group by partcol2",
     "select max(c1) from (select partcol1 + 1 as c1 from srcpart where partcol1 = 0) t")
 
+  testMetadataOnly(
+    "SPARK-31590 The filter used by Metadata-only queries should not have Unevaluable",
+    """
+      |SELECT partcol1, MAX(partcol2) AS partcol2
+      |FROM srcpart
+      |WHERE partcol1 = (
+      |  SELECT MAX(partcol1)
+      |  FROM srcpart
+      |)
+      |AND partcol2= 'event'
+      |GROUP BY partcol1
+      |""".stripMargin
+  )

Review comment:
       Sorry, I typed an extra letter t, it should be the existing partition value to filter.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org