You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by ramkrish86 <gi...@git.apache.org> on 2016/03/17 05:50:00 UTC
[GitHub] flink pull request: [FLINK-3579] Improve String concatenation
GitHub user ramkrish86 opened a pull request:
https://github.com/apache/flink/pull/1808
[FLINK-3579] Improve String concatenation
I think this time I got the PR correctly. Last time I did not select the right branch while creating the PR but the code was created with tableOnCalcite branch. Sorry about that.
As said in JIRA I have some doubts with that 'cast' operator change becasue the parser itself was written with **'.cast(BYTE)'** etc. where the **.** operator was explicit.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ramkrish86/flink FLINK-3579_tableOnCalcite
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1808.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1808
----
commit 2b1a2b2af4b9535dfa7802cdadf0b96678abc3b3
Author: ramkrishna <ra...@gmail.com>
Date: 2016-03-17T04:45:43Z
[FLINK-3579] Improve String concatenation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3579] Improve String concatenation
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1808
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3579] Improve String concatenation
Posted by ramkrish86 <gi...@git.apache.org>.
Github user ramkrish86 commented on the pull request:
https://github.com/apache/flink/pull/1808#issuecomment-198203789
I could see some failure in the log console
JobManagerSubmittedJobGraphsRecoveryITCase. But not related to the patch. Is there a place where we could see the failed test cases alone as how the Jenkins build shows us?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3579] Improve String concatenation
Posted by ramkrish86 <gi...@git.apache.org>.
Github user ramkrish86 commented on the pull request:
https://github.com/apache/flink/pull/1808#issuecomment-199109373
@hsaputra
I am waiting for @tillrohrmann reviews. Why did this get closed am not sure. Any way to open it back?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3579] Improve String concatenation
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1808#issuecomment-199146677
grasping at straws here: when was the tableOnCalcite branch deleted?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3579] Improve String concatenation
Posted by vasia <gi...@git.apache.org>.
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1808#issuecomment-199321446
`tableOnCalcite` was deleted on Friday, but it seems that this PR was closed yesterday, so I'm not sure if that's why.
Sorry for the inconvenience @ramkrish86!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3579] Improve String concatenation
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1808#issuecomment-199026680
Anyone merged this PR as part of commit to Flink ASF Git repo?
I wonder why asfgit close this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---