You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/12/08 14:10:55 UTC

[GitHub] [camel-k] gansheer opened a new pull request, #3884: feat(cli): Update Kamel bind step index in properties to start at 1 instead of 0

gansheer opened a new pull request, #3884:
URL: https://github.com/apache/camel-k/pull/3884

   fixes 2586
   
   ## Motivation
   
   The `kamel bind` command  uses 0 index start for the definition of step properties : 
   ```sh
   kamel bind ... --step my-step-1 --step my-step-2 -p step-0.my-key=value1 -p step-1.my-key=value2
   ```
   
   Having an index start at 1 is more user friendly : 
   ```shell
   kamel bind ... --step my-step-1 --step my-step-2 -p step-1.my-key=value1 -p step-2.my-key=value2
   ```
   ## Modifications
   
   * Modify the transformation from command to spec for steps in biding command code
   * Add a unit test on step values
   
   
   **Release Note**
   ```release-note
   feat(cli): Update Kamel bind step index in properties to start at 1 instead of 0
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] squakez merged pull request #3884: feat(cli): Update Kamel bind step index in properties to start at 1 instead of 0

Posted by GitBox <gi...@apache.org>.

squakez merged PR #3884:
URL: https://github.com/apache/camel-k/pull/3884


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-k] squakez commented on pull request #3884: feat(cli): Update Kamel bind step index in properties to start at 1 instead of 0

Posted by GitBox <gi...@apache.org>.

squakez commented on PR #3884:
URL: https://github.com/apache/camel-k/pull/3884#issuecomment-1346105886

   Thanks for your contribution!!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org