You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/04/06 11:40:43 UTC
[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2114: HDDS-5062. Add a config to bypass clusterId validation for bootstrapping SCM.
bharatviswa504 commented on a change in pull request #2114:
URL: https://github.com/apache/ozone/pull/2114#discussion_r607770831
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestStorageContainerManagerHA.java
##########
@@ -228,4 +230,25 @@ public void testPrimordialSCM() throws Exception {
Assert.assertTrue(
StorageContainerManager.scmInit(conf2, scm2.getClusterId()));
}
+
+ @Test
+ public void testBootStrapSCM() throws Exception {
+ StorageContainerManager scm1 = cluster.getStorageContainerManagers().get(0);
+ StorageContainerManager scm2 = cluster.getStorageContainerManagers().get(1);
+ OzoneConfiguration conf2 = scm2.getConfiguration();
+ conf2.set(ScmConfigKeys.OZONE_SCM_PRIMORDIAL_NODE_ID_KEY,
Review comment:
Same line duplicated
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestStorageContainerManagerHA.java
##########
@@ -228,4 +230,25 @@ public void testPrimordialSCM() throws Exception {
Assert.assertTrue(
StorageContainerManager.scmInit(conf2, scm2.getClusterId()));
}
+
+ @Test
+ public void testBootStrapSCM() throws Exception {
+ StorageContainerManager scm1 = cluster.getStorageContainerManagers().get(0);
+ StorageContainerManager scm2 = cluster.getStorageContainerManagers().get(1);
+ OzoneConfiguration conf2 = scm2.getConfiguration();
+ conf2.set(ScmConfigKeys.OZONE_SCM_PRIMORDIAL_NODE_ID_KEY,
Review comment:
And also do we need this setting here for this test case?
##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/scm/TestStorageContainerManagerHA.java
##########
@@ -228,4 +230,25 @@ public void testPrimordialSCM() throws Exception {
Assert.assertTrue(
StorageContainerManager.scmInit(conf2, scm2.getClusterId()));
}
+
+ @Test
+ public void testBootStrapSCM() throws Exception {
+ StorageContainerManager scm1 = cluster.getStorageContainerManagers().get(0);
+ StorageContainerManager scm2 = cluster.getStorageContainerManagers().get(1);
+ OzoneConfiguration conf2 = scm2.getConfiguration();
+ conf2.set(ScmConfigKeys.OZONE_SCM_PRIMORDIAL_NODE_ID_KEY,
+ scm1.getSCMNodeId());
+ conf2.set(ScmConfigKeys.OZONE_SCM_PRIMORDIAL_NODE_ID_KEY,
+ scm1.getSCMNodeId());
+ boolean isDeleted = scm2.getScmStorageConfig().getVersionFile().delete();
+ Assert.assertTrue(isDeleted);
+ final SCMStorageConfig scmStorageConfig = new SCMStorageConfig(conf2);
+ scmStorageConfig.setClusterId(UUID.randomUUID().toString());
+ scmStorageConfig.getCurrentDir().delete();
+ scmStorageConfig.initialize();
Review comment:
So test here is delete scm2 version file.
L246-249 created a new version file for SCM2 in same location with new clusterID.
Now we are check with/without OZONE_SCM_SKIP_BOOTSTRAP_VALIDATION_KEY?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org