You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/04/09 20:03:05 UTC
[GitHub] [incubator-livy] codecov-io edited a comment on issue #168:
[LIVY-563] Propagate RSC configuration when creating sessions.
codecov-io edited a comment on issue #168: [LIVY-563] Propagate RSC configuration when creating sessions.
URL: https://github.com/apache/incubator-livy/pull/168#issuecomment-481413422
# [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/168?src=pr&el=h1) Report
> Merging [#168](https://codecov.io/gh/apache/incubator-livy/pull/168?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/d5b27dd430e8f5d4e149125eb433fd61e3e24c00?src=pr&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `75%`.
[](https://codecov.io/gh/apache/incubator-livy/pull/168?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #168 +/- ##
============================================
- Coverage 68.82% 68.58% -0.25%
+ Complexity 907 905 -2
============================================
Files 100 100
Lines 5662 5666 +4
Branches 848 850 +2
============================================
- Hits 3897 3886 -11
- Misses 1213 1226 +13
- Partials 552 554 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/168?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [rsc/src/main/java/org/apache/livy/rsc/RSCConf.java](https://codecov.io/gh/apache/incubator-livy/pull/168/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9SU0NDb25mLmphdmE=) | `85.84% <ø> (ø)` | `7 <0> (ø)` | :arrow_down: |
| [...e/livy/server/interactive/InteractiveSession.scala](https://codecov.io/gh/apache/incubator-livy/pull/168/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvaW50ZXJhY3RpdmUvSW50ZXJhY3RpdmVTZXNzaW9uLnNjYWxh) | `69.11% <75%> (+0.07%)` | `44 <0> (ø)` | :arrow_down: |
| [...ain/scala/org/apache/livy/utils/SparkYarnApp.scala](https://codecov.io/gh/apache/incubator-livy/pull/168/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9TcGFya1lhcm5BcHAuc2NhbGE=) | `72.53% <0%> (-7.05%)` | `33% <0%> (ø)` | |
| [...cala/org/apache/livy/scalaapi/ScalaJobHandle.scala](https://codecov.io/gh/apache/incubator-livy/pull/168/diff?src=pr&el=tree#diff-c2NhbGEtYXBpL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zY2FsYWFwaS9TY2FsYUpvYkhhbmRsZS5zY2FsYQ==) | `50% <0%> (-5.89%)` | `7% <0%> (ø)` | |
| [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/168/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `78.81% <0%> (-1.28%)` | `42% <0%> (ø)` | |
| [...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/168/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==) | `35.96% <0%> (+0.49%)` | `11% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/168?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/168?src=pr&el=footer). Last update [d5b27dd...b1f682a](https://codecov.io/gh/apache/incubator-livy/pull/168?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services