You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/07 04:29:44 UTC
[GitHub] [kafka] johnthotekat opened a new pull request #9133: KAFKA-10316: Updated Kafka Streams upgrade notes.
johnthotekat opened a new pull request #9133:
URL: https://github.com/apache/kafka/pull/9133
* Added the details on KIP-648 to 2.7.0 upgrade notes - `docs/streams/upgrade-guide.html`
@mjsax
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] johnthotekat commented on pull request #9133: KAFKA-10316: Updated Kafka Streams upgrade notes.
Posted by GitBox <gi...@apache.org>.
johnthotekat commented on pull request #9133:
URL: https://github.com/apache/kafka/pull/9133#issuecomment-670823191
This branch got a little messed up during the rebase :(
Raised another PR https://github.com/apache/kafka/pull/9146
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on a change in pull request #9133: KAFKA-10316: Updated Kafka Streams upgrade notes.
Posted by GitBox <gi...@apache.org>.
mjsax commented on a change in pull request #9133:
URL: https://github.com/apache/kafka/pull/9133#discussion_r467244495
##########
File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java
##########
@@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo activeHost, final Set<HostInfo> standbyHo
}
/**
- * Get the Active streams instance for given key
Review comment:
Not sure. I am not an git guru... Can you maybe just rebase this PR against latest trunk (just to make sure we don't mess anything up?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] johnthotekat commented on a change in pull request #9133: KAFKA-10316: Updated Kafka Streams upgrade notes.
Posted by GitBox <gi...@apache.org>.
johnthotekat commented on a change in pull request #9133:
URL: https://github.com/apache/kafka/pull/9133#discussion_r467236707
##########
File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java
##########
@@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo activeHost, final Set<HostInfo> standbyHo
}
/**
- * Get the Active streams instance for given key
Review comment:
If you see from the commit history in the timeline . My last commit is : https://github.com/apache/kafka/pull/9133/commits/14ab0529a492e9b1d361b1ab3081b8fa7189632f (this has only the html changes) and all the ones before that are already merged to trunk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] johnthotekat commented on a change in pull request #9133: KAFKA-10316: Updated Kafka Streams upgrade notes.
Posted by GitBox <gi...@apache.org>.
johnthotekat commented on a change in pull request #9133:
URL: https://github.com/apache/kafka/pull/9133#discussion_r467236707
##########
File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java
##########
@@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo activeHost, final Set<HostInfo> standbyHo
}
/**
- * Get the Active streams instance for given key
Review comment:
If you see from the commit history in the timeline . My last commit is : https://github.com/apache/kafka/pull/9133/commits/14ab0529a492e9b1d361b1ab3081b8fa7189632f (this has only the html changes) and all the ones before that are already merged to trunk. Am I missing something here for the previous changes to show up in this PR too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on a change in pull request #9133: KAFKA-10316: Updated Kafka Streams upgrade notes.
Posted by GitBox <gi...@apache.org>.
mjsax commented on a change in pull request #9133:
URL: https://github.com/apache/kafka/pull/9133#discussion_r467233225
##########
File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java
##########
@@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo activeHost, final Set<HostInfo> standbyHo
}
/**
- * Get the Active streams instance for given key
Review comment:
As the original PR is merged already, this seems to be redundant (similar below for all other code changes). -- This PR should only update the html file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] johnthotekat commented on pull request #9133: KAFKA-10316: Updated Kafka Streams upgrade notes.
Posted by GitBox <gi...@apache.org>.
johnthotekat commented on pull request #9133:
URL: https://github.com/apache/kafka/pull/9133#issuecomment-670322175
@mjsax I've checked the actual documentations and just to make sure I've also checked for the occurrence of the deprecated methods throughout the repo and found none (except in the classes and upgrade-guide which we modified).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] johnthotekat commented on a change in pull request #9133: KAFKA-10316: Updated Kafka Streams upgrade notes.
Posted by GitBox <gi...@apache.org>.
johnthotekat commented on a change in pull request #9133:
URL: https://github.com/apache/kafka/pull/9133#discussion_r467235567
##########
File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java
##########
@@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo activeHost, final Set<HostInfo> standbyHo
}
/**
- * Get the Active streams instance for given key
Review comment:
Yeah , this should only update the html file. I raised the PR from the same branch. Err., I wonder, as these changes were already merged, should it even be showing these as changes here ? I'm saying about the previous changes which were already merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] johnthotekat edited a comment on pull request #9133: KAFKA-10316: Updated Kafka Streams upgrade notes.
Posted by GitBox <gi...@apache.org>.
johnthotekat edited a comment on pull request #9133:
URL: https://github.com/apache/kafka/pull/9133#issuecomment-670823191
Closing this PR. Raised another PR https://github.com/apache/kafka/pull/9146 .
This branch got a little messed up during the rebase :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] johnthotekat closed pull request #9133: KAFKA-10316: Updated Kafka Streams upgrade notes.
Posted by GitBox <gi...@apache.org>.
johnthotekat closed pull request #9133:
URL: https://github.com/apache/kafka/pull/9133
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org