[GitHub] [trafficserver] brbzull0 commented on a change in pull request #7232: Fix lua_states_stats Au test.

[GitBox <gi...@apache.org>]

brbzull0 commented on a change in pull request #7232:
URL: https://github.com/apache/trafficserver/pull/7232#discussion_r505648834



##########
File path: tests/gold_tests/pluginTest/lua/metrics.sh
##########
@@ -0,0 +1,31 @@
+#  Licensed to the Apache Software Foundation (ASF) under one
+#  or more contributor license agreements.  See the NOTICE file
+#  distributed with this work for additional information
+#  regarding copyright ownership.  The ASF licenses this file
+#  to you under the Apache License, Version 2.0 (the
+#  "License"); you may not use this file except in compliance
+#  with the License.  You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License.
+
+N=60
+while (( N > 0 ))
+do
+    rm -f metrics.out metrics.txt
+    traffic_ctl metric match lua > metrics.out

Review comment:
       would it make more sense to just get all the metrics by explicitly mention their names?  can occur that we  get more metrics than the ones you defined in the `metrics.gold`? probably *not* as this is isolated in this test(worth asking). In any case if you request for a record that does not exist you will get an error out of the `traffic_ctl` (in case you request  `traffic_ctl metric get a b c`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org