set_temp_dir ?

["David N. Welton" <da...@dedasys.com>]

I have this in my local source, and am trying to figure out why it's
not in the 'upstream' code.

#define ApacheRequest_set_temp_dir(req, dir) (req->temp_dir = dir)

Did I just forget to commit it/send it to this list, or...?

-- 
David N. Welton
   Consulting: http://www.dedasys.com/
     Personal: http://www.dedasys.com/davidw/
Free Software: http://www.dedasys.com/freesoftware/
   Apache Tcl: http://tcl.apache.org/

Re: set_temp_dir ?

[Joe Schaefer <jo...@sunstarsys.com>]

davidw@dedasys.com (David N. Welton) writes:

> It seems as if my test was broken - I didn't have the final
> "$boundary--".  It would still be nice if it didn't corrupt 
> the data because of that, but oh well...

Six of one, half-dozen of the other :-) 

Once we leave the confines of the RFCs, it's 
hard to prioritize which type of behavior is "worse".
Looking forward, it might be better for apreq-2 parsers 
to just raise a passive error on similar RFC violations, 
and let somebody else (content handler, downstream input 
filter, etc.) figure out what to do with the mangled POST 
data.

-- 
Joe Schaefer

Re: set_temp_dir ?

["David N. Welton" <da...@dedasys.com>]

It seems as if my test was broken - I didn't have the final
"$boundary--".  It would still be nice if it didn't corrupt the data
because of that, but oh well...

-- 
David N. Welton
   Consulting: http://www.dedasys.com/
     Personal: http://www.dedasys.com/davidw/
Free Software: http://www.dedasys.com/freesoftware/
   Apache Tcl: http://tcl.apache.org/

Re: set_temp_dir ?

["David N. Welton" <da...@dedasys.com>]

Joe Schaefer <jo...@sunstarsys.com> writes:

> Just checked- it's not in my local cvs either.  +1 to a commit
> though, it definitely belongs there.

Done.

While we're at it, there appears to be something not quite right with
the 'mozilla' hack for the upload code.  It used to pass the test
suite in Rivet, and now it doesn't.  It seems to truncate the last bit
of the file.

I am investigating at the moment... I'll keep you posted.

-- 
David N. Welton
   Consulting: http://www.dedasys.com/
     Personal: http://www.dedasys.com/davidw/
Free Software: http://www.dedasys.com/freesoftware/
   Apache Tcl: http://tcl.apache.org/

Re: set_temp_dir ?

[Joe Schaefer <jo...@sunstarsys.com>]

davidw@dedasys.com (David N. Welton) writes:

> I have this in my local source, and am trying to figure out why it's
> not in the 'upstream' code.
> 
> #define ApacheRequest_set_temp_dir(req, dir) (req->temp_dir = dir)
> 
> Did I just forget to commit it/send it to this list, or...?

Just checked- it's not in my local cvs either.  +1 to a commit
though, it definitely belongs there.

Hmm, it also needs documenting in libapreq.pod, and libapreq.pod 
is currently somewhat out-of-sync with apache_request.h. (There 
are a couple of undocumented macros in apache_request.h ).

Any volunteers to bring libapreq.pod up to speed with the 
current header files?

-- 
Joe Schaefer