[GitHub] haojin2 commented on a change in pull request #11179: [MXNET-404] elemwise_add/sub between rsp and rsp on GPU

[GitBox <gi...@apache.org>]

haojin2 commented on a change in pull request #11179: [MXNET-404] elemwise_add/sub between rsp and rsp on GPU
URL: https://github.com/apache/incubator-mxnet/pull/11179#discussion_r193574058
 
 

 ##########
 File path: include/mxnet/ndarray.h
 ##########
 @@ -156,7 +156,7 @@ class NDArray {
   }
 
   /* \brief Check whether the two arrays are the same array */
-  inline bool IsSame(const NDArray& other) {
+  inline bool IsSame(const NDArray& other) const {
 
 Review comment:
   @piiswrong I made the change here so that I can also call this function when I have a ``` const NDArray``` object.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services