You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/10 18:25:42 UTC
[GitHub] [arrow] nealrichardson opened a new pull request #7147: ARROW-8758: [R] Updates for compatibility with dplyr 1.0
nealrichardson opened a new pull request #7147:
URL: https://github.com/apache/arrow/pull/7147
I tested this locally with the current version of `dplyr` on CRAN and the dev version scheduled to be released to CRAN on May 15. Our tests now pass with both versions.
Changes addressed:
* `group_by` now requires a character vector of grouping variable names, so now we use `group_vars()` instead of `groups()`. `group_vars()` works in the current `dplyr` release, so this is a simple change.
* The argument name in `group_by()` changed from `add` to `.add`, and calling it with the name that works in the current version raises a deprecation warning in dplyr 1.0. The fix here supports both spellings of the argument, and it avoids the warning by determining which version of the internal dplyr function exists and calling the appropriate one.
* `dplyr::transmute()` no longer calls `dplyr::mutate()` internally, so it doesn't just work on Arrow objects anymore. I skipped the one test that called it and left a TODO to add a transmute method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7147: ARROW-8758: [R] Updates for compatibility with dplyr 1.0
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7147:
URL: https://github.com/apache/arrow/pull/7147#issuecomment-626369581
https://issues.apache.org/jira/browse/ARROW-8758
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org