[jira] [Comment Edited] (HBASE-22631) assign failed may make gced parent region appear again !!!

["yuhuiyang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-22631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16904969#comment-16904969 ] 

yuhuiyang edited comment on HBASE-22631 at 8/12/19 8:28 AM:
------------------------------------------------------------

 I am cofused by how to write a UT for it . How can i simulate that the region can not be open for hdfs problem but can be opend in another regionserver for hdfs problem fixed.

[^assignProcedure.txt] is my test log . 

Follows are my test log photo for third stages:

stage1 : assign failure in tempt20 and success in tempt21.
 !assign.png!
 stage2:  split and deleted for gcprocedure. 
 !splitAndGc.png! 
 stage3: tempt20 crash and region appear again .
 !serverCrash.png!


was (Author: yu-huiyang):
 I am cofused by how to write a UT for it . How can i simulate that the region can not be open for hdfs can be opend in another regionserver .

[^assignProcedure.txt] is my test log . 

Follows are my test log photo for third stages:

stage1 : assign failure in tempt20 and success in tempt21.
 !assign.png!
stage2:  split and deleted for gcprocedure. 
 !splitAndGc.png! 
stage3: tempt20 crash and region appear again .
 !serverCrash.png! 


> assign failed may make gced parent region appear again !!!
> ----------------------------------------------------------
>
>                 Key: HBASE-22631
>                 URL: https://issues.apache.org/jira/browse/HBASE-22631
>             Project: HBase
>          Issue Type: Bug
>          Components: proc-v2
>    Affects Versions: 2.1.1
>            Reporter: yuhuiyang
>            Priority: Major
>         Attachments: HBASE-22631-branch-2.1-01.patch, assign.png, assignProcedure.txt, serverCrash.png, splitAndGc.png
>
>
> When i assign a region A the process is as follows：
> step1 : A is assigned to rs1 , and rs1 fails to open it .
> step2 : assignProcedure handleFailure .
> step3 : A is assign to rs2 and rs success to open it .
> Above is the normal flow . However when rs1 is restart after the reigon A was split and GCRegionProcedure was successed , the region A appare again !
> The region is that reigon A is not removed from the serverMap correctly when assignprocedure handleFailure . Because the code regionNode.offline() make the regionNode's regionLocation to be null and make regionNode's state to OFFLINE . So when the code env.getAssignmentManager().undoRegionAsOpening(regionNode) do nothing . So when the rs1 restart event triggers a serverCrashProcedure, it will get reigons from serverMap and it will get the region A then A will be assigned and hdfs dir will be created. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)