Patch to fix Client issues on 1.4

[Steven Isaacson <sp...@gmail.com>]

The current Client code does not work on a 1.4 JVM since the
String.replace method doesn't exist. I have attached a patch to change
the CacheControlParser to use String.replaceAll.

Thanks,
-steve

Re: Patch to fix Client issues on 1.4

[Garrett Rooney <ro...@electricjellyfish.net>]

On 10/2/06, Steven Isaacson <sp...@gmail.com> wrote:
> On 10/2/06, Garrett Rooney <ro...@electricjellyfish.net> wrote:
> > Applied in r452065.  Thanks!
> >
> > By the way, in the future if you could make your patches relative to
> > the 'trunk' directory instead of the top of the tree that would be
> > easier.  Are you actually checking out the root of the
> > incubator/abdera directory?  That's kind of a bad idea, and will
> > result in checking out an awful lot of stuff you don't really need
> > (i.e. all our branches and tags).
>
> I think I did check out the root at one point because I wanted to also
> get the 0.1.0 snapshot.

Well, it's fine at the moment, but it gets less and less good as time
goes on and we get more tags and branches, both in terms of disk space
used in your working copy and load on the server for checkouts.

> I think I saw someone else with a patch relative to java. Though from
> now on I will make my patches relative to trunk.

Thanks!  And thanks again for the patch!

-garrett

Re: Patch to fix Client issues on 1.4

[Steven Isaacson <sp...@gmail.com>]

On 10/2/06, Garrett Rooney <ro...@electricjellyfish.net> wrote:
> Applied in r452065.  Thanks!
>
> By the way, in the future if you could make your patches relative to
> the 'trunk' directory instead of the top of the tree that would be
> easier.  Are you actually checking out the root of the
> incubator/abdera directory?  That's kind of a bad idea, and will
> result in checking out an awful lot of stuff you don't really need
> (i.e. all our branches and tags).

I think I did check out the root at one point because I wanted to also
get the 0.1.0 snapshot.

I think I saw someone else with a patch relative to java. Though from
now on I will make my patches relative to trunk.

-steve

Re: Patch to fix Client issues on 1.4

[Garrett Rooney <ro...@electricjellyfish.net>]

On 10/2/06, Steven Isaacson <sp...@gmail.com> wrote:
> The current Client code does not work on a 1.4 JVM since the
> String.replace method doesn't exist. I have attached a patch to change
> the CacheControlParser to use String.replaceAll.

Applied in r452065.  Thanks!

By the way, in the future if you could make your patches relative to
the 'trunk' directory instead of the top of the tree that would be
easier.  Are you actually checking out the root of the
incubator/abdera directory?  That's kind of a bad idea, and will
result in checking out an awful lot of stuff you don't really need
(i.e. all our branches and tags).

-garrett