You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by Vladimir Sitnikov <si...@gmail.com> on 2014/11/28 22:33:04 UTC
pull requests at github
Hi,
I scanned through pull requests at
https://github.com/apache/incubator-calcite/pulls and realized that:
1) I have no write permissions there. Is that something that can be fixed?
2) Some PRs are merged (like CALCITE-464 in
https://github.com/apache/incubator-calcite/pull/19), however PR is
active.
3) TravisCI does not test PRs. Is it supposed to test pull requests?
--
Regards,
Vladimir Sitnikov
Re: pull requests at github
Posted by James Taylor <ja...@apache.org>.
We use Apache's Jenkins for Phoenix.
On Sun, Nov 30, 2014 at 8:29 PM, Julian Hyde <ju...@hydromatic.net> wrote:
>
>> On Nov 28, 2014, at 1:33 PM, Vladimir Sitnikov <si...@gmail.com> wrote:
>>
>> Hi,
>>
>> I scanned through pull requests at
>> https://github.com/apache/incubator-calcite/pulls and realized that:
>> 1) I have no write permissions there. Is that something that can be fixed?
>
> Apparently not. See https://issues.apache.org/jira/browse/INFRA-8434 (and I recall the Spark team had a similar response when they asked for access to the Apache github user).
>
>> 2) Some PRs are merged (like CALCITE-464 in
>> https://github.com/apache/incubator-calcite/pull/19), however PR is
>> active.
>
> This could be closed by using a 'Close apache/incubator-calcite#19' commit comment. I don't like to create a dummy commit, and I keep forgetting to add the comment to regular commits.
>
>> 3) TravisCI does not test PRs. Is it supposed to test pull requests?
>
> The Travis setup isn't ideal. It tests the julianhyde/incubator-calcite master branch, which works for me personally, but there is much room for improvement.
>
> Most important, we should run tests on the apache master branch whenever there is a commit.
>
> I don't know whether we should use Travis CI or Apache's Jenkins. What do other projects do?
>
> Julian
>
Re: pull requests at github
Posted by Julian Hyde <ju...@hydromatic.net>.
> On Nov 28, 2014, at 1:33 PM, Vladimir Sitnikov <si...@gmail.com> wrote:
>
> Hi,
>
> I scanned through pull requests at
> https://github.com/apache/incubator-calcite/pulls and realized that:
> 1) I have no write permissions there. Is that something that can be fixed?
Apparently not. See https://issues.apache.org/jira/browse/INFRA-8434 (and I recall the Spark team had a similar response when they asked for access to the Apache github user).
> 2) Some PRs are merged (like CALCITE-464 in
> https://github.com/apache/incubator-calcite/pull/19), however PR is
> active.
This could be closed by using a 'Close apache/incubator-calcite#19' commit comment. I don't like to create a dummy commit, and I keep forgetting to add the comment to regular commits.
> 3) TravisCI does not test PRs. Is it supposed to test pull requests?
The Travis setup isn't ideal. It tests the julianhyde/incubator-calcite master branch, which works for me personally, but there is much room for improvement.
Most important, we should run tests on the apache master branch whenever there is a commit.
I don't know whether we should use Travis CI or Apache's Jenkins. What do other projects do?
Julian