You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@uima.apache.org by GitBox <gi...@apache.org> on 2020/10/15 21:24:30 UTC

[GitHub] [uima-uimaj] reckart commented on a change in pull request #66: [UIMA 6273] isBeforeV3 variable not reset in BinaryCasSerDes

reckart commented on a change in pull request #66:
URL: https://github.com/apache/uima-uimaj/pull/66#discussion_r505865511



##########
File path: uimaj-core/src/main/java/org/apache/uima/cas/impl/BinaryCasSerDes.java
##########
@@ -559,8 +553,10 @@ public SerialFormat reinit(Header h,
       if (!delta) {
         baseCas.resetNoQuestions();
       }
-      
-      
+
+      // isBeforeV3 adjusts binary type numbers, and is reset with the CAS when !delta, so it must be set here.
+      isBeforeV3 = !h.isV3 && h.getSeqVersionNbr() < 2;

Review comment:
       Isn't this line even enough? Do we need to clear the flag in the reset call?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org