[jira] [Commented] (MESOS-2291) Move executor driver validations to slave

["Alexander Rojas (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-2291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338364#comment-14338364 ] 

Alexander Rojas commented on MESOS-2291:
----------------------------------------

I've been looking at this issue for a couple of days, and after reviewing it with [~tillt] I'm even more unsure if there's anything to do here. For example, there is the following check:

{code:title=void ExecutorProcess::sendStatusUpdate(const TaskStatus& status)}
    if (status.state() == TASK_STAGING) {
      LOG(ERROR) << "Executor is not allowed to send "
                 << "TASK_STAGING status update. Aborting!";

      driver->abort();

      Stopwatch stopwatch;
      if (FLAGS_v >= 1) {
        stopwatch.start();
      }

      executor->error(driver, "Attempted to send TASK_STAGING status update");

      VLOG(1) << "Executor::error took " << stopwatch.elapsed();

      return;
    }
{code}

Which is handled in the slave already (I'm actually wondering if aborting on the wrong state value is the right thing to do):

{code:title=void Slave::statusUpdate(const StatusUpdate& update, const UPID& pid)}
  CHECK(state == RECOVERING || state == DISCONNECTED ||
        state == RUNNING || state == TERMINATING)
    << state;
{code}

The executor driver also keeps track of the unacknowledged status and tasks, for which I am not sure about the wisdom of tracking them on the slave, since they are used mostly to internal executor book keeping.

> Move executor driver validations to slave
> -----------------------------------------
>
>                 Key: MESOS-2291
>                 URL: https://issues.apache.org/jira/browse/MESOS-2291
>             Project: Mesos
>          Issue Type: Task
>            Reporter: Vinod Kone
>
> With HTTP API, the executor driver will no longer exist and hence all the validations should move to the slave. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)