You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by jc...@apache.org on 2009/05/07 16:14:10 UTC

svn commit: r772653 - /wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js

Author: jcompagner
Date: Thu May  7 14:14:10 2009
New Revision: 772653

URL: http://svn.apache.org/viewvc?rev=772653&view=rev
Log:
isSafari breaks chrome (the onLoad doesnt happen at all)
still works on safari as normal

Modified:
    wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js

Modified: wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js?rev=772653&r1=772652&r2=772653&view=diff
==============================================================================
--- wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js (original)
+++ wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js Thu May  7 14:14:10 2009
@@ -613,7 +613,7 @@
 
 	
 		// opera seems to have problem accessing contentWindow here
-		if (Wicket.Browser.isOpera() || Wicket.Browser.isSafari()) {
+		if (Wicket.Browser.isOpera()) {
 			this.content.onload = function() {
 				this.content.contentWindow.name = this.settings.iframeName;
 			}



Re: svn commit: r772653 - /wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js

Posted by Igor Vaynberg <ig...@gmail.com>.
are you going ot commit this to trunk?

-igor

On Thu, May 7, 2009 at 7:14 AM,  <jc...@apache.org> wrote:
> Author: jcompagner
> Date: Thu May  7 14:14:10 2009
> New Revision: 772653
>
> URL: http://svn.apache.org/viewvc?rev=772653&view=rev
> Log:
> isSafari breaks chrome (the onLoad doesnt happen at all)
> still works on safari as normal
>
> Modified:
>    wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
>
> Modified: wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
> URL: http://svn.apache.org/viewvc/wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js?rev=772653&r1=772652&r2=772653&view=diff
> ==============================================================================
> --- wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js (original)
> +++ wicket/branches/wicket-1.3.x/jdk-1.4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js Thu May  7 14:14:10 2009
> @@ -613,7 +613,7 @@
>
>
>                // opera seems to have problem accessing contentWindow here
> -               if (Wicket.Browser.isOpera() || Wicket.Browser.isSafari()) {
> +               if (Wicket.Browser.isOpera()) {
>                        this.content.onload = function() {
>                                this.content.contentWindow.name = this.settings.iframeName;
>                        }
>
>
>