You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/06/03 19:13:59 UTC
[jira] [Commented] (FALCON-2010) Fix UT errors due to ActiveMQ
upgrade
[ https://issues.apache.org/jira/browse/FALCON-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15314623#comment-15314623 ]
ASF GitHub Bot commented on FALCON-2010:
----------------------------------------
GitHub user yzheng-hortonworks opened a pull request:
https://github.com/apache/falcon/pull/169
FALCON-2010 Fix UT errors due to ActiveMQ upgrade
Fixed two test failures due to the upgrade:
1. JMSMessageConsumerTest
After upgrade, some messages are consumed faster and so the initial expectation on no message being dequeued right after the message sending doesn't hold. Also confirmed with @bvellanki that this kind of tests are flaky and have caused intermittent test errors before. Therefore, removed getTotalDequeueCount assertion. In addition, the expected message consumptions are tested in existing code "Mockito.verify(jobEndService,...".
2. FalconPostProcessingTest
After upgrade, Falcon will run into an error if it tries to delete messages when ActiveMQ service is stopped. Therefore, need to call start before deleting the message during teardown.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yzheng-hortonworks/falcon FALCON-2010
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/falcon/pull/169.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #169
----
commit 950407a7a956d25b07c1fc39ebdd3d0eca86195b
Author: yzheng-hortonworks <yz...@hortonworks.com>
Date: 2016-06-03T19:12:04Z
FALCON-2010 Fix UT errors due to ActiveMQ upgrade
----
> Fix UT errors due to ActiveMQ upgrade
> -------------------------------------
>
> Key: FALCON-2010
> URL: https://issues.apache.org/jira/browse/FALCON-2010
> Project: Falcon
> Issue Type: Bug
> Reporter: Ying Zheng
> Assignee: Ying Zheng
> Fix For: trunk, 0.10
>
>
> JMSMessageConsumerTest and FalconPostProcessingTest fail after upgrading ActiveMQ to 5.13.x.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)