You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alexandreyc (via GitHub)" <gi...@apache.org> on 2024/04/19 07:53:25 UTC
[PR] Move ffi stream and utils from arrow to arrow-array [arrow-rs]
alexandreyc opened a new pull request, #5670:
URL: https://github.com/apache/arrow-rs/pull/5670
# Which issue does this PR close?
Closes #5663.
# Rationale for this change
We have to depend on `arrow` for using the C Stream Interface for ADBC while we would prefer to depend on smaller crates.
# Are there any user-facing changes?
I don't think so but please double check.
# Notes
- I had to remove usage of compute kernels within tests because this introduces a dev-dependency cycle (arrow-array <-> arrow-arith) which is problematic for the `Array` trait. See https://doc.rust-lang.org/cargo/reference/resolver.html#dev-dependency-cycles
- I had to redefine `Result<T> = std::result::Result<T, ArrowError>` because it's only defined in `arrow`. Maybe we should move it to `arrow_schema` alongside `ArrowError`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move ffi stream and utils from arrow to arrow-array [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #5670:
URL: https://github.com/apache/arrow-rs/pull/5670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move ffi stream and utils from arrow to arrow-array [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #5670:
URL: https://github.com/apache/arrow-rs/pull/5670#discussion_r1574503228
##########
arrow-array/src/ffi_stream.rs:
##########
@@ -63,14 +63,16 @@ use std::{
sync::Arc,
};
+use arrow_data::ffi::FFI_ArrowArray;
+use arrow_schema::{ffi::FFI_ArrowSchema, ArrowError, Schema, SchemaRef};
+
use crate::array::Array;
use crate::array::StructArray;
-use crate::datatypes::{Schema, SchemaRef};
-use crate::error::ArrowError;
-use crate::error::Result;
-use crate::ffi::*;
+use crate::ffi::from_ffi_and_data_type;
use crate::record_batch::{RecordBatch, RecordBatchReader};
+type Result<T> = std::result::Result<T, ArrowError>; // TODO(alexandreyc): we should probably move Result to arrow_schema
Review Comment:
I had feedback from some people that overloading Result was confusing, I happen to think it reduces code verbosity and quite like it, but that's the history of why it didn't get moved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move ffi stream and utils from arrow to arrow-array [arrow-rs]
Posted by "alexandreyc (via GitHub)" <gi...@apache.org>.
alexandreyc commented on PR #5670:
URL: https://github.com/apache/arrow-rs/pull/5670#issuecomment-2069131518
CI is green now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org