You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/19 01:59:53 UTC
[GitHub] [tvm] masahi commented on a diff in pull request #10504: Complete pytorch grid_sample
masahi commented on code in PR #10504:
URL: https://github.com/apache/tvm/pull/10504#discussion_r852532644
##########
tests/python/relay/test_op_level5.py:
##########
@@ -1423,10 +1442,23 @@ def verify_grid_sample(data_shape, grid_shape, padding_mode="zeros"):
)
tvm.testing.assert_allclose(op_res1.numpy(), ref_res, rtol=1e-5, atol=1e-5)
- verify_grid_sample((4, 4, 16, 32), (4, 2, 8, 8))
- verify_grid_sample((4, 4, 16, 32), (4, 2, 32, 32))
- verify_grid_sample((4, 4, 16, 32), (4, 2, 8, 8), "border")
- verify_grid_sample((4, 4, 16, 32), (4, 2, 32, 32), "border")
+ methods = ["nearest", "bilinear", "bicubic"]
+ padding_modes = ["zeros", "border", "reflection"]
+ align_corners = [True, False]
+
+ data_2D_shape = (4, 4, 8, 8)
+ grid_2D_shape = (4, 2, 16, 16)
+ data_3D_shape = (4, 4, 8, 8, 8)
+ grid_3D_shape = (4, 3, 16, 16, 16)
+
+ for _method in methods:
+ for _padding in padding_modes:
+ for _align in align_corners:
+ verify_grid_sample(data_2D_shape, grid_2D_shape, _method, _padding, _align)
+
+ # 3D "bicubic"(tricubic) is not supported in pytorch
Review Comment:
This is not pytorch test
##########
tests/python/topi/python/test_topi_image.py:
##########
@@ -307,9 +314,28 @@ def check_target(target, dev):
for target, dev in tvm.testing.enabled_targets():
check_target(target, dev)
- verify_grid_sample((4, 4, 16, 32), (4, 2, 8, 8))
- verify_grid_sample((4, 4, 16, 32), (4, 2, 32, 32), "border")
- verify_grid_sample((4, 4, 16, 32), (4, 2, 8, 8), "border")
+ methods = ["nearest", "bilinear", "bicubic"]
+ padding_modes = ["zeros", "border", "reflection"]
+ align_corners = [True, False]
+ data_2D_shape = (4, 4, 8, 8)
+ grid_2D_shape = (4, 2, 16, 16)
+ layout_2D = "NCHW"
+ data_3D_shape = (4, 4, 8, 8, 8)
+ grid_3D_shape = (4, 3, 16, 16, 16)
+ layout_3D = "NCDHW"
+
+ for _method in methods:
+ for _padding in padding_modes:
+ for _align in align_corners:
+ verify_grid_sample(
+ data_2D_shape, grid_2D_shape, _method, layout_2D, _padding, _align
+ )
+
+ # 3D "bicubic"(tricubic) is not supported in pytorch
Review Comment:
This is not pytorch test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org