[GitHub] [airflow] mik-laj commented on a change in pull request #11515: Remove flask-admin based Plugins

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #11515:
URL: https://github.com/apache/airflow/pull/11515#discussion_r504335879



##########
File path: airflow/plugins_manager.py
##########
@@ -256,29 +248,18 @@ def initialize_web_ui_plugins():
 
     log.debug("Initialize Web UI plugin")
 
-    admin_views = []
     flask_blueprints = []
-    menu_links = []
     flask_appbuilder_views = []
     flask_appbuilder_menu_links = []
 
     for plugin in plugins:
-        admin_views.extend(plugin.admin_views)
-        menu_links.extend(plugin.menu_links)
         flask_appbuilder_views.extend(plugin.appbuilder_views)
         flask_appbuilder_menu_links.extend(plugin.appbuilder_menu_items)
         flask_blueprints.extend([{
             'name': plugin.name,
             'blueprint': bp
         } for bp in plugin.flask_blueprints])
 
-        if (admin_views and not flask_appbuilder_views) or (menu_links and not flask_appbuilder_menu_links):

Review comment:
       ```
   if (plugin.admin_views and not plugin.appbuilder_views) or (plugin.menu_links and not plugin.flask_appbuilder_menu_links):
   ```
   In my opinion, this message may remain, but it seems to me that the global variable can be deleted completely. Users who migrate to RBAC proposed by airflow upgrade-check may not be aware of the consequences.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org