You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Gargi-jais11 (via GitHub)" <gi...@apache.org> on 2026/06/10 04:10:40 UTC

[PR] HDDS-15509. Add protobuf schema and OmBucketInfo storage for S3 bucket tags [ozone]

Gargi-jais11 opened a new pull request, #10475:
URL: https://github.com/apache/ozone/pull/10475

   ## What changes were proposed in this pull request?
   This is the first base PR for S3 Bucket Tagging implementation.
   Introduce  protocol definitions required for S3 **PutBucketTagging, GetBucketTagging, and DeleteBucketTagging**.
   No OM request handlers or S3 endpoints in this PR — only the persistence/schema layer so later PRs can build on a stable contract.
   
   - **OmClientProtocol.proto**
   
   1.   Add PutBucketTagging, GetBucketTagging, DeleteBucketTagging to Type enum
   2. - Add request/response messages
   3. - Add repeated KeyValue tags = 23 to BucketInfo
   4. - Add repeated KeyValue tags = 13 to BucketArgs
   5. - OmBucketInfo.java — store/serialize/deserialize tags map
   
   - **OmBucketArgs.java** — carry tags in bucket args
   - **OzoneManagerVersion.java** — add S3_BUCKET_TAGGING_API(13, ...)
   - **OmUtils.java** — classify PutBucketTagging / DeleteBucketTagging as write 
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-15509
   
   ## How was this patch tested?
   
   Passed CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-15509. Add protobuf schema and OmBucketInfo storage for S3 bucket tags [ozone]

Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 merged PR #10475:
URL: https://github.com/apache/ozone/pull/10475


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-15509. Add protobuf schema and OmBucketInfo storage for S3 bucket tags [ozone]

Posted by "ivandika3 (via GitHub)" <gi...@apache.org>.
ivandika3 commented on PR #10475:
URL: https://github.com/apache/ozone/pull/10475#issuecomment-4677247833

   Thanks @Gargi-jais11 for the patch and @peterxcli @adoroszlai for the reviews.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-15509. Add protobuf schema and OmBucketInfo storage for S3 bucket tags [ozone]

Posted by "peterxcli (via GitHub)" <gi...@apache.org>.
peterxcli commented on code in PR #10475:
URL: https://github.com/apache/ozone/pull/10475#discussion_r3390243718


##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########


Review Comment:
   the 2.2 proto lock just got merged, https://github.com/apache/ozone/pull/10466.
   is it good to merge this change before the release cutoff? (I'm not familiar to the release process)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-15509. Add protobuf schema and OmBucketInfo storage for S3 bucket tags [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #10475:
URL: https://github.com/apache/ozone/pull/10475#discussion_r3390590005


##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########


Review Comment:
   Protobuf changes should ideally go into the same release as the functionality that needs it.  This way we can tweak it, if needed, until that release, without backward compatibility issues.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-15509. Add protobuf schema and OmBucketInfo storage for S3 bucket tags [ozone]

Posted by "Gargi-jais11 (via GitHub)" <gi...@apache.org>.
Gargi-jais11 commented on code in PR #10475:
URL: https://github.com/apache/ozone/pull/10475#discussion_r3393194519


##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########


Review Comment:
   Thanks @adoroszlai for the info. Should I merge this PR now?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org