[GitHub] [nifi] simonbence commented on a change in pull request #4689: NIFI-8039 Adding properties to ListenTCP in order to allow refine behaviour under higher load; Refining thread pool for better scalability

[GitBox <gi...@apache.org>]

simonbence commented on a change in pull request #4689:
URL: https://github.com/apache/nifi/pull/4689#discussion_r531040364



##########
File path: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/listen/dispatcher/ByteBufferSource.java
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processor.util.listen.dispatcher;
+
+import java.nio.ByteBuffer;
+
+/**
+ * Manages byte buffers for the dispatchers.
+ */
+public interface ByteBufferSource {
+
+    /**
+     * @return Returns for a buffer for usage. It is not guaranteed tha the buffer is created ad hoc. If the source is
+     * not capable to provide an instance, it returns {@code null} instead.
+     */
+    ByteBuffer acquireBuffer();
+
+    /**
+     * With calling this method the client releases the buffer. It might be reused by the handler and not to be used
+     * by this client any more.
+     *
+     * @param byteBuffer The byte buffer the client acquired previously.
+     */
+    void release(ByteBuffer byteBuffer);

Review comment:
       Good point, it's some inconsistency remained in the naming during some change, thanks!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org