You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2016/11/02 03:59:25 UTC

Review Request 53367: Optimize tag-download to include only tags that have policies

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53367/
-----------------------------------------------------------

Review request for ranger and Madhan Neethiraj.


Bugs: RANGER-1199
    https://issues.apache.org/jira/browse/RANGER-1199


Repository: ranger


Description
-------

For the calls to download tags from plugins, Ranger Admin returns all the service-resources that have one or more tags associated. This can be optimized to include only service-resources that have tags for which policies exists.


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/biz/RangerTagDBRetriever.java 0949092 
  security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java d709869 
  security-admin/src/main/java/org/apache/ranger/db/XXServiceResourceDao.java 71bbfab 
  security-admin/src/main/java/org/apache/ranger/db/XXServiceResourceElementDao.java 240eb62 
  security-admin/src/main/java/org/apache/ranger/db/XXServiceResourceElementValueDao.java d324331 
  security-admin/src/main/java/org/apache/ranger/db/XXTagAttributeDao.java a24e3db 
  security-admin/src/main/java/org/apache/ranger/db/XXTagAttributeDefDao.java 294c222 
  security-admin/src/main/java/org/apache/ranger/db/XXTagDao.java 199a155 
  security-admin/src/main/java/org/apache/ranger/db/XXTagDefDao.java 86793ec 
  security-admin/src/main/java/org/apache/ranger/db/XXTagResourceMapDao.java 40dbe86 
  security-admin/src/main/java/org/apache/ranger/service/RangerServiceResourceService.java e5937e6 
  security-admin/src/main/resources/META-INF/jpa_named_queries.xml 4fcf0ea 

Diff: https://reviews.apache.org/r/53367/diff/


Testing
-------

Tested with local VM.


Thanks,

Abhay Kulkarni


Re: Review Request 53367: Optimize tag-download to include only tags that have policies

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53367/#review154510
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Nov. 2, 2016, 3:59 a.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53367/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2016, 3:59 a.m.)
> 
> 
> Review request for ranger and Madhan Neethiraj.
> 
> 
> Bugs: RANGER-1199
>     https://issues.apache.org/jira/browse/RANGER-1199
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> For the calls to download tags from plugins, Ranger Admin returns all the service-resources that have one or more tags associated. This can be optimized to include only service-resources that have tags for which policies exists.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/RangerTagDBRetriever.java 0949092 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java d709869 
>   security-admin/src/main/java/org/apache/ranger/db/XXServiceResourceDao.java 71bbfab 
>   security-admin/src/main/java/org/apache/ranger/db/XXServiceResourceElementDao.java 240eb62 
>   security-admin/src/main/java/org/apache/ranger/db/XXServiceResourceElementValueDao.java d324331 
>   security-admin/src/main/java/org/apache/ranger/db/XXTagAttributeDao.java a24e3db 
>   security-admin/src/main/java/org/apache/ranger/db/XXTagAttributeDefDao.java 294c222 
>   security-admin/src/main/java/org/apache/ranger/db/XXTagDao.java 199a155 
>   security-admin/src/main/java/org/apache/ranger/db/XXTagDefDao.java 86793ec 
>   security-admin/src/main/java/org/apache/ranger/db/XXTagResourceMapDao.java 40dbe86 
>   security-admin/src/main/java/org/apache/ranger/service/RangerServiceResourceService.java e5937e6 
>   security-admin/src/main/resources/META-INF/jpa_named_queries.xml 4fcf0ea 
> 
> Diff: https://reviews.apache.org/r/53367/diff/
> 
> 
> Testing
> -------
> 
> Tested with local VM.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>