You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Carl Steinbach <ca...@cloudera.com> on 2011/10/21 22:34:15 UTC

Review Request: HIVE-2391. published POMs in Maven repo are incorrect

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2529/
-----------------------------------------------------------

Review request for hive and John Sichi.


Summary
-------

Review request for HIVE-2391.


This addresses bug HIVE-2391.
    https://issues.apache.org/jira/browse/HIVE-2391


Diffs
-----

  ant/build.xml c4351d0 
  ant/ivy.xml deb96f0 
  build-common.xml 37b32ec 
  build.properties fc80b03 
  build.xml 20494ca 
  cli/ivy.xml 0595d94 
  cli/lib/README 446b0e6 
  cli/lib/jline-0.9.94.LICENSE 246f54f 
  cli/lib/jline-0.9.94.jar dafca7c 
  common/ivy.xml 722249e 
  contrib/build.xml 14e1e20 
  contrib/ivy.xml 100cc03 
  contrib/src/test/queries/clientpositive/dboutput.q dbbcfcb 
  hbase-handler/build.xml f45dbfc 
  hbase-handler/ivy.xml 9b4b38f 
  hwi/build.xml 4919570 
  hwi/ivy.xml 1860b66 
  ivy/libraries.properties 8d88562 
  jdbc/build.xml 641938a 
  jdbc/ivy.xml bc9c69e 
  lib/README 6e993ee 
  lib/asm-3.1.LICENSE 75ad085 
  lib/asm-3.1.jar b3baf3f 
  lib/commons-collections-3.2.1.LICENSE 261eeb9 
  lib/commons-collections-3.2.1.jar c35fa1f 
  lib/commons-lang-2.4.LICENSE 261eeb9 
  lib/commons-lang-2.4.jar 532939e 
  lib/commons-logging-1.0.4.jar b73a80f 
  lib/commons-logging-api-1.0.4.jar ade9a13 
  lib/derby.LICENSE 261eeb9 
  lib/derby.jar dbdc454 
  lib/json-LICENSE.txt a8c1705 
  lib/json-README.txt 67b8909 
  lib/json.jar 219760c 
  lib/log4j-1.2.15.jar c930a6a 
  lib/velocity-1.5.jar 7c7f2c4 
  lib/velocity.LICENSE 261eeb9 
  metastore/build.xml af46bc9 
  metastore/ivy.xml 7d90b25 
  odbc/ivy.xml PRE-CREATION 
  pdk/build.xml 374e5d1 
  pdk/ivy.xml 411e126 
  ql/build.xml 8b22508 
  ql/ivy.xml a09e970 
  ql/lib/README d11400e 
  ql/lib/antlr-2.7.7.LICENSE 1d1d5d6 
  ql/lib/antlr-2.7.7.jar 5e5f14b 
  ql/lib/antlr-3.0.1.LICENSE 1d1d5d6 
  ql/lib/antlr-3.0.1.jar 7d37952 
  ql/lib/antlr-runtime-3.0.1.LICENSE 1d1d5d6 
  ql/lib/antlr-runtime-3.0.1.jar b2efb5b 
  ql/lib/stringtemplate-3.1b1.LICENSE 1d1d5d6 
  ql/lib/stringtemplate-3.1b1.jar 096f863 
  serde/build.xml 471c43d 
  serde/ivy.xml 290cb6c 
  service/build.xml 10e8cf1 
  service/ivy.xml c37efdc 
  shims/build.xml 3930ca2 
  shims/ivy.xml c1785aa 

Diff: https://reviews.apache.org/r/2529/diff


Testing
-------

Verified that 'ant clean package' works. Also ran some testcases. Currently running full regression tests.


Thanks,

Carl


Re: Review Request: HIVE-2391. published POMs in Maven repo are incorrect

Posted by Carl Steinbach <ca...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2529/
-----------------------------------------------------------

(Updated 2011-11-04 22:36:42.714354)


Review request for hive and John Sichi.


Changes
-------

Updated patch. Fixes test failures caused by classpath issue affecting stats db, and set_processor_namespaces.q


Summary
-------

Review request for HIVE-2391.


This addresses bug HIVE-2391.
    https://issues.apache.org/jira/browse/HIVE-2391


Diffs (updated)
-----

  ant/build.xml c4351d0 
  ant/ivy.xml deb96f0 
  build-common.xml 37b32ec 
  build.properties fc80b03 
  build.xml a3a95a5 
  cli/build.xml 958cfe7 
  cli/ivy.xml 0595d94 
  cli/lib/README 446b0e6 
  cli/lib/jline-0.9.94.LICENSE 246f54f 
  cli/lib/jline-0.9.94.jar dafca7c 
  common/build.xml 66322dc 
  common/ivy.xml 722249e 
  contrib/build.xml 14e1e20 
  contrib/ivy.xml 100cc03 
  contrib/src/test/queries/clientpositive/dboutput.q dbbcfcb 
  eclipse-templates/.classpath 1b97ae9 
  hbase-handler/build.xml f45dbfc 
  hbase-handler/ivy.xml 9b4b38f 
  hwi/build.xml 4919570 
  hwi/ivy.xml 1860b66 
  ivy.xml 566bb40 
  ivy/common-configurations.xml PRE-CREATION 
  ivy/ivysettings.xml a2587c7 
  ivy/libraries.properties 8d88562 
  jdbc/build.xml 641938a 
  jdbc/ivy.xml bc9c69e 
  lib/README 6e993ee 
  lib/asm-3.1.LICENSE 75ad085 
  lib/asm-3.1.jar b3baf3f 
  lib/commons-collections-3.2.1.LICENSE 261eeb9 
  lib/commons-collections-3.2.1.jar c35fa1f 
  lib/commons-lang-2.4.LICENSE 261eeb9 
  lib/commons-lang-2.4.jar 532939e 
  lib/commons-logging-1.0.4.jar b73a80f 
  lib/commons-logging-api-1.0.4.jar ade9a13 
  lib/derby.LICENSE 261eeb9 
  lib/derby.jar dbdc454 
  lib/json-LICENSE.txt a8c1705 
  lib/json-README.txt 67b8909 
  lib/json.jar 219760c 
  lib/log4j-1.2.15.jar c930a6a 
  lib/velocity-1.5.jar 7c7f2c4 
  lib/velocity.LICENSE 261eeb9 
  metastore/build.xml af46bc9 
  metastore/ivy.xml 7d90b25 
  odbc/ivy.xml PRE-CREATION 
  pdk/build.xml 374e5d1 
  pdk/ivy.xml 411e126 
  ql/build.xml 8b22508 
  ql/ivy.xml a09e970 
  ql/lib/README d11400e 
  ql/lib/antlr-2.7.7.LICENSE 1d1d5d6 
  ql/lib/antlr-2.7.7.jar 5e5f14b 
  ql/lib/antlr-3.0.1.LICENSE 1d1d5d6 
  ql/lib/antlr-3.0.1.jar 7d37952 
  ql/lib/antlr-runtime-3.0.1.LICENSE 1d1d5d6 
  ql/lib/antlr-runtime-3.0.1.jar b2efb5b 
  ql/lib/stringtemplate-3.1b1.LICENSE 1d1d5d6 
  ql/lib/stringtemplate-3.1b1.jar 096f863 
  ql/src/test/queries/clientpositive/set_processor_namespaces.q 8fe2eb8 
  ql/src/test/results/clientpositive/set_processor_namespaces.q.out a365e2c 
  serde/build.xml 471c43d 
  serde/ivy.xml 290cb6c 
  service/build.xml 10e8cf1 
  service/ivy.xml c37efdc 
  shims/build.xml 3930ca2 
  shims/ivy.xml c1785aa 

Diff: https://reviews.apache.org/r/2529/diff


Testing
-------

Verified that 'ant clean package' works. Also ran some testcases. Currently running full regression tests.


Thanks,

Carl


Re: Review Request: HIVE-2391. published POMs in Maven repo are incorrect

Posted by Carl Steinbach <ca...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2529/
-----------------------------------------------------------

(Updated 2011-11-04 07:30:29.507801)


Review request for hive and John Sichi.


Changes
-------

Updated patch:
* Include cross-project dependencies.
* Remove commented code in build.xml
* Updated Eclipse classpath template

Verified that the following Ant targets work: jar, package, tar, binary, checkstyle, eclipse-files, maven-build, maven-publish.


Summary
-------

Review request for HIVE-2391.


This addresses bug HIVE-2391.
    https://issues.apache.org/jira/browse/HIVE-2391


Diffs (updated)
-----

  ant/build.xml c4351d0 
  ant/ivy.xml deb96f0 
  build-common.xml 37b32ec 
  build.properties fc80b03 
  build.xml a3a95a5 
  cli/build.xml 958cfe7 
  cli/ivy.xml 0595d94 
  cli/lib/README 446b0e6 
  cli/lib/jline-0.9.94.LICENSE 246f54f 
  cli/lib/jline-0.9.94.jar dafca7c 
  common/build.xml 66322dc 
  common/ivy.xml 722249e 
  contrib/build.xml 14e1e20 
  contrib/ivy.xml 100cc03 
  contrib/src/test/queries/clientpositive/dboutput.q dbbcfcb 
  eclipse-templates/.classpath 1b97ae9 
  hbase-handler/build.xml f45dbfc 
  hbase-handler/ivy.xml 9b4b38f 
  hwi/build.xml 4919570 
  hwi/ivy.xml 1860b66 
  ivy.xml 566bb40 
  ivy/common-configurations.xml PRE-CREATION 
  ivy/ivysettings.xml a2587c7 
  ivy/libraries.properties 8d88562 
  jdbc/build.xml 641938a 
  jdbc/ivy.xml bc9c69e 
  lib/README 6e993ee 
  lib/asm-3.1.LICENSE 75ad085 
  lib/asm-3.1.jar b3baf3f 
  lib/commons-collections-3.2.1.LICENSE 261eeb9 
  lib/commons-collections-3.2.1.jar c35fa1f 
  lib/commons-lang-2.4.LICENSE 261eeb9 
  lib/commons-lang-2.4.jar 532939e 
  lib/commons-logging-1.0.4.jar b73a80f 
  lib/commons-logging-api-1.0.4.jar ade9a13 
  lib/derby.LICENSE 261eeb9 
  lib/derby.jar dbdc454 
  lib/json-LICENSE.txt a8c1705 
  lib/json-README.txt 67b8909 
  lib/json.jar 219760c 
  lib/log4j-1.2.15.jar c930a6a 
  lib/velocity-1.5.jar 7c7f2c4 
  lib/velocity.LICENSE 261eeb9 
  metastore/build.xml af46bc9 
  metastore/ivy.xml 7d90b25 
  odbc/ivy.xml PRE-CREATION 
  pdk/build.xml 374e5d1 
  pdk/ivy.xml 411e126 
  ql/build.xml 8b22508 
  ql/ivy.xml a09e970 
  ql/lib/README d11400e 
  ql/lib/antlr-2.7.7.LICENSE 1d1d5d6 
  ql/lib/antlr-2.7.7.jar 5e5f14b 
  ql/lib/antlr-3.0.1.LICENSE 1d1d5d6 
  ql/lib/antlr-3.0.1.jar 7d37952 
  ql/lib/antlr-runtime-3.0.1.LICENSE 1d1d5d6 
  ql/lib/antlr-runtime-3.0.1.jar b2efb5b 
  ql/lib/stringtemplate-3.1b1.LICENSE 1d1d5d6 
  ql/lib/stringtemplate-3.1b1.jar 096f863 
  serde/build.xml 471c43d 
  serde/ivy.xml 290cb6c 
  service/build.xml 10e8cf1 
  service/ivy.xml c37efdc 
  shims/build.xml 3930ca2 
  shims/ivy.xml c1785aa 

Diff: https://reviews.apache.org/r/2529/diff


Testing
-------

Verified that 'ant clean package' works. Also ran some testcases. Currently running full regression tests.


Thanks,

Carl


Re: Review Request: HIVE-2391. published POMs in Maven repo are incorrect

Posted by Carl Steinbach <ca...@cloudera.com>.

> On 2011-10-23 09:56:59, Amareshwari Sriramadasu wrote:
> > build.xml, line 719
> > <https://reviews.apache.org/r/2529/diff/2/?file=52288#file52288line719>
> >
> >     Minor : Can you remove the commented code, if not required?

Done.


- Carl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2529/#review2783
-----------------------------------------------------------


On 2011-10-21 22:02:10, Carl Steinbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2529/
> -----------------------------------------------------------
> 
> (Updated 2011-10-21 22:02:10)
> 
> 
> Review request for hive and John Sichi.
> 
> 
> Summary
> -------
> 
> Review request for HIVE-2391.
> 
> 
> This addresses bug HIVE-2391.
>     https://issues.apache.org/jira/browse/HIVE-2391
> 
> 
> Diffs
> -----
> 
>   ant/build.xml c4351d0 
>   ant/ivy.xml deb96f0 
>   build-common.xml 37b32ec 
>   build.properties fc80b03 
>   build.xml 20494ca 
>   cli/ivy.xml 0595d94 
>   cli/lib/README 446b0e6 
>   cli/lib/jline-0.9.94.LICENSE 246f54f 
>   cli/lib/jline-0.9.94.jar dafca7c 
>   common/ivy.xml 722249e 
>   contrib/build.xml 14e1e20 
>   contrib/ivy.xml 100cc03 
>   contrib/src/test/queries/clientpositive/dboutput.q dbbcfcb 
>   hbase-handler/build.xml f45dbfc 
>   hbase-handler/ivy.xml 9b4b38f 
>   hwi/build.xml 4919570 
>   hwi/ivy.xml 1860b66 
>   ivy/libraries.properties 8d88562 
>   jdbc/build.xml 641938a 
>   jdbc/ivy.xml bc9c69e 
>   lib/README 6e993ee 
>   lib/asm-3.1.LICENSE 75ad085 
>   lib/asm-3.1.jar b3baf3f 
>   lib/commons-collections-3.2.1.LICENSE 261eeb9 
>   lib/commons-collections-3.2.1.jar c35fa1f 
>   lib/commons-lang-2.4.LICENSE 261eeb9 
>   lib/commons-lang-2.4.jar 532939e 
>   lib/commons-logging-1.0.4.jar b73a80f 
>   lib/commons-logging-api-1.0.4.jar ade9a13 
>   lib/derby.LICENSE 261eeb9 
>   lib/derby.jar dbdc454 
>   lib/json-LICENSE.txt a8c1705 
>   lib/json-README.txt 67b8909 
>   lib/json.jar 219760c 
>   lib/log4j-1.2.15.jar c930a6a 
>   lib/velocity-1.5.jar 7c7f2c4 
>   lib/velocity.LICENSE 261eeb9 
>   metastore/build.xml af46bc9 
>   metastore/ivy.xml 7d90b25 
>   odbc/ivy.xml PRE-CREATION 
>   pdk/build.xml 374e5d1 
>   pdk/ivy.xml 411e126 
>   ql/build.xml 8b22508 
>   ql/ivy.xml a09e970 
>   ql/lib/README d11400e 
>   ql/lib/antlr-2.7.7.LICENSE 1d1d5d6 
>   ql/lib/antlr-2.7.7.jar 5e5f14b 
>   ql/lib/antlr-3.0.1.LICENSE 1d1d5d6 
>   ql/lib/antlr-3.0.1.jar 7d37952 
>   ql/lib/antlr-runtime-3.0.1.LICENSE 1d1d5d6 
>   ql/lib/antlr-runtime-3.0.1.jar b2efb5b 
>   ql/lib/stringtemplate-3.1b1.LICENSE 1d1d5d6 
>   ql/lib/stringtemplate-3.1b1.jar 096f863 
>   serde/build.xml 471c43d 
>   serde/ivy.xml 290cb6c 
>   service/build.xml 10e8cf1 
>   service/ivy.xml c37efdc 
>   shims/build.xml 3930ca2 
>   shims/ivy.xml c1785aa 
> 
> Diff: https://reviews.apache.org/r/2529/diff
> 
> 
> Testing
> -------
> 
> Verified that 'ant clean package' works. Also ran some testcases. Currently running full regression tests.
> 
> 
> Thanks,
> 
> Carl
> 
>


Re: Review Request: HIVE-2391. published POMs in Maven repo are incorrect

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2529/#review2783
-----------------------------------------------------------



build.xml
<https://reviews.apache.org/r/2529/#comment6244>

    Minor : Can you remove the commented code, if not required?


- Amareshwari


On 2011-10-21 22:02:10, Carl Steinbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2529/
> -----------------------------------------------------------
> 
> (Updated 2011-10-21 22:02:10)
> 
> 
> Review request for hive and John Sichi.
> 
> 
> Summary
> -------
> 
> Review request for HIVE-2391.
> 
> 
> This addresses bug HIVE-2391.
>     https://issues.apache.org/jira/browse/HIVE-2391
> 
> 
> Diffs
> -----
> 
>   ant/build.xml c4351d0 
>   ant/ivy.xml deb96f0 
>   build-common.xml 37b32ec 
>   build.properties fc80b03 
>   build.xml 20494ca 
>   cli/ivy.xml 0595d94 
>   cli/lib/README 446b0e6 
>   cli/lib/jline-0.9.94.LICENSE 246f54f 
>   cli/lib/jline-0.9.94.jar dafca7c 
>   common/ivy.xml 722249e 
>   contrib/build.xml 14e1e20 
>   contrib/ivy.xml 100cc03 
>   contrib/src/test/queries/clientpositive/dboutput.q dbbcfcb 
>   hbase-handler/build.xml f45dbfc 
>   hbase-handler/ivy.xml 9b4b38f 
>   hwi/build.xml 4919570 
>   hwi/ivy.xml 1860b66 
>   ivy/libraries.properties 8d88562 
>   jdbc/build.xml 641938a 
>   jdbc/ivy.xml bc9c69e 
>   lib/README 6e993ee 
>   lib/asm-3.1.LICENSE 75ad085 
>   lib/asm-3.1.jar b3baf3f 
>   lib/commons-collections-3.2.1.LICENSE 261eeb9 
>   lib/commons-collections-3.2.1.jar c35fa1f 
>   lib/commons-lang-2.4.LICENSE 261eeb9 
>   lib/commons-lang-2.4.jar 532939e 
>   lib/commons-logging-1.0.4.jar b73a80f 
>   lib/commons-logging-api-1.0.4.jar ade9a13 
>   lib/derby.LICENSE 261eeb9 
>   lib/derby.jar dbdc454 
>   lib/json-LICENSE.txt a8c1705 
>   lib/json-README.txt 67b8909 
>   lib/json.jar 219760c 
>   lib/log4j-1.2.15.jar c930a6a 
>   lib/velocity-1.5.jar 7c7f2c4 
>   lib/velocity.LICENSE 261eeb9 
>   metastore/build.xml af46bc9 
>   metastore/ivy.xml 7d90b25 
>   odbc/ivy.xml PRE-CREATION 
>   pdk/build.xml 374e5d1 
>   pdk/ivy.xml 411e126 
>   ql/build.xml 8b22508 
>   ql/ivy.xml a09e970 
>   ql/lib/README d11400e 
>   ql/lib/antlr-2.7.7.LICENSE 1d1d5d6 
>   ql/lib/antlr-2.7.7.jar 5e5f14b 
>   ql/lib/antlr-3.0.1.LICENSE 1d1d5d6 
>   ql/lib/antlr-3.0.1.jar 7d37952 
>   ql/lib/antlr-runtime-3.0.1.LICENSE 1d1d5d6 
>   ql/lib/antlr-runtime-3.0.1.jar b2efb5b 
>   ql/lib/stringtemplate-3.1b1.LICENSE 1d1d5d6 
>   ql/lib/stringtemplate-3.1b1.jar 096f863 
>   serde/build.xml 471c43d 
>   serde/ivy.xml 290cb6c 
>   service/build.xml 10e8cf1 
>   service/ivy.xml c37efdc 
>   shims/build.xml 3930ca2 
>   shims/ivy.xml c1785aa 
> 
> Diff: https://reviews.apache.org/r/2529/diff
> 
> 
> Testing
> -------
> 
> Verified that 'ant clean package' works. Also ran some testcases. Currently running full regression tests.
> 
> 
> Thanks,
> 
> Carl
> 
>


Re: Review Request: HIVE-2391. published POMs in Maven repo are incorrect

Posted by Carl Steinbach <ca...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2529/
-----------------------------------------------------------

(Updated 2011-10-21 22:02:10.187459)


Review request for hive and John Sichi.


Changes
-------

Updating the diff with new Ivy version number.


Summary
-------

Review request for HIVE-2391.


This addresses bug HIVE-2391.
    https://issues.apache.org/jira/browse/HIVE-2391


Diffs (updated)
-----

  ant/build.xml c4351d0 
  ant/ivy.xml deb96f0 
  build-common.xml 37b32ec 
  build.properties fc80b03 
  build.xml 20494ca 
  cli/ivy.xml 0595d94 
  cli/lib/README 446b0e6 
  cli/lib/jline-0.9.94.LICENSE 246f54f 
  cli/lib/jline-0.9.94.jar dafca7c 
  common/ivy.xml 722249e 
  contrib/build.xml 14e1e20 
  contrib/ivy.xml 100cc03 
  contrib/src/test/queries/clientpositive/dboutput.q dbbcfcb 
  hbase-handler/build.xml f45dbfc 
  hbase-handler/ivy.xml 9b4b38f 
  hwi/build.xml 4919570 
  hwi/ivy.xml 1860b66 
  ivy/libraries.properties 8d88562 
  jdbc/build.xml 641938a 
  jdbc/ivy.xml bc9c69e 
  lib/README 6e993ee 
  lib/asm-3.1.LICENSE 75ad085 
  lib/asm-3.1.jar b3baf3f 
  lib/commons-collections-3.2.1.LICENSE 261eeb9 
  lib/commons-collections-3.2.1.jar c35fa1f 
  lib/commons-lang-2.4.LICENSE 261eeb9 
  lib/commons-lang-2.4.jar 532939e 
  lib/commons-logging-1.0.4.jar b73a80f 
  lib/commons-logging-api-1.0.4.jar ade9a13 
  lib/derby.LICENSE 261eeb9 
  lib/derby.jar dbdc454 
  lib/json-LICENSE.txt a8c1705 
  lib/json-README.txt 67b8909 
  lib/json.jar 219760c 
  lib/log4j-1.2.15.jar c930a6a 
  lib/velocity-1.5.jar 7c7f2c4 
  lib/velocity.LICENSE 261eeb9 
  metastore/build.xml af46bc9 
  metastore/ivy.xml 7d90b25 
  odbc/ivy.xml PRE-CREATION 
  pdk/build.xml 374e5d1 
  pdk/ivy.xml 411e126 
  ql/build.xml 8b22508 
  ql/ivy.xml a09e970 
  ql/lib/README d11400e 
  ql/lib/antlr-2.7.7.LICENSE 1d1d5d6 
  ql/lib/antlr-2.7.7.jar 5e5f14b 
  ql/lib/antlr-3.0.1.LICENSE 1d1d5d6 
  ql/lib/antlr-3.0.1.jar 7d37952 
  ql/lib/antlr-runtime-3.0.1.LICENSE 1d1d5d6 
  ql/lib/antlr-runtime-3.0.1.jar b2efb5b 
  ql/lib/stringtemplate-3.1b1.LICENSE 1d1d5d6 
  ql/lib/stringtemplate-3.1b1.jar 096f863 
  serde/build.xml 471c43d 
  serde/ivy.xml 290cb6c 
  service/build.xml 10e8cf1 
  service/ivy.xml c37efdc 
  shims/build.xml 3930ca2 
  shims/ivy.xml c1785aa 

Diff: https://reviews.apache.org/r/2529/diff


Testing
-------

Verified that 'ant clean package' works. Also ran some testcases. Currently running full regression tests.


Thanks,

Carl