You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by HuangWHWHW <gi...@git.apache.org> on 2015/09/15 08:41:08 UTC
[GitHub] flink pull request: [hotfix][Table API tests]add toDataSet in tabl...
GitHub user HuangWHWHW opened a pull request:
https://github.com/apache/flink/pull/1131
[hotfix][Table API tests]add toDataSet in table API tests
See the discussion in the PR:https://github.com/apache/flink/pull/1098 for detail.
And I'm not sure this change need a JIRA or just take a hotfix.
The problem is due to the ambiguous Table APIs between DataSet.scala and DataStream.scala.
The class Table can call methods in both DataSet.scala and DataStream.scala.
The class Table need to specify `toDataSet` or `toDataStream` firstly when there are the same methods in both DataSet.scala and DataStream.scala.
So I added the `toDataSet`(since there is only one method in DataSet.scala recently but further will be another in DataStream.scala) in these Table API tests for the follow-up working in DataStream.scala.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HuangWHWHW/flink FLINK-2622-toDataSet
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1131.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1131
----
commit 62741ca7cfe6620d94717fe9eb6909e34da763d0
Author: HuangWHWHW <40...@qq.com>
Date: 2015-09-15T06:28:17Z
[hotfix][Table API tests]add toDataSet in table API tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix][Table API tests]add toDataSet in tabl...
Posted by HuangWHWHW <gi...@git.apache.org>.
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/1131#issuecomment-140386897
Hello? I got the last CI log, this seems to be passed?
Why display failure in this web?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix][Table API tests]add toDataSet in tabl...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1131#issuecomment-140418355
I think this is OK, it just ensures that the code is non-ambiguous. So for me it looks good-to-merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix][Table API tests]add toDataSet in tabl...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1131#issuecomment-140749715
I will merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix][Table API tests]add toDataSet in tabl...
Posted by chiwanpark <gi...@git.apache.org>.
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1131#issuecomment-140658458
Looks good to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix][Table API tests]add toDataSet in tabl...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1131#issuecomment-140420760
+1 from me too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix][Table API tests]add toDataSet in tabl...
Posted by HuangWHWHW <gi...@git.apache.org>.
Github user HuangWHWHW commented on the pull request:
https://github.com/apache/flink/pull/1131#issuecomment-140933982
Many thanks!
This solved a big problem of mine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix][Table API tests]add toDataSet in tabl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1131
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---