You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/18 22:41:00 UTC
[jira] [Commented] (KAFKA-6382) Make ProducerConfig and
ConsumerConfig constructors public
[ https://issues.apache.org/jira/browse/KAFKA-6382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295780#comment-16295780 ]
ASF GitHub Bot commented on KAFKA-6382:
---------------------------------------
GitHub user mjsax opened a pull request:
https://github.com/apache/kafka/pull/4341
KAFKA-6382: Make ProducerConfig and ConsumerConfig constructors public
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjsax/kafka kafka-6382-make-config-constructors-public
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/4341.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4341
----
commit d4eef0a21fe71ab8c2e5ca9eaefb6e15752fa6dd
Author: Matthias J. Sax <ma...@confluent.io>
Date: 2017-12-18T22:39:49Z
KAFKA-6382: Make ProducerConfig and ConsumerConfig constructors public
----
> Make ProducerConfig and ConsumerConfig constructors public
> ----------------------------------------------------------
>
> Key: KAFKA-6382
> URL: https://issues.apache.org/jira/browse/KAFKA-6382
> Project: Kafka
> Issue Type: Improvement
> Components: clients
> Affects Versions: 1.0.0
> Reporter: Matthias J. Sax
> Assignee: Matthias J. Sax
> Priority: Minor
> Fix For: 1.1.0
>
>
> Constructors of {{ProducerConfig}} and {{ConsumerConfig}} are not public atm. This makes it hard to access default values for configurations. For Kafka Streams, we need access to those default value sometime and are forces to hardcode them via c&p atm.
> KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-243%3A+Make+ProducerConfig+and+ConsumerConfig+constructors+public
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)