You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/01/09 14:48:23 UTC
[GitHub] [incubator-echarts-doc] susiwen8 opened a new pull request #87: Fix
doc
susiwen8 opened a new pull request #87: Fix doc
URL: https://github.com/apache/incubator-echarts-doc/pull/87
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] Ovilia commented on issue #87: Fix doc
Posted by GitBox <gi...@apache.org>.
Ovilia commented on issue #87: Fix doc
URL: https://github.com/apache/incubator-echarts-doc/pull/87#issuecomment-581144685
@susiwen8 Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] Ovilia commented on a change in pull
request #87: Fix doc
Posted by GitBox <gi...@apache.org>.
Ovilia commented on a change in pull request #87: Fix doc
URL: https://github.com/apache/incubator-echarts-doc/pull/87#discussion_r368786543
##########
File path: zh/option/component/visual-map-piecewise.md
##########
@@ -183,11 +183,11 @@ series.data 的 `dataMin` 和 `dataMax`）。
兼容 ECharts2，当有 `text` 时，label不显示。
-## textGap(Array) = 10
+## textGap(number) = 10
两端文字主体之间的距离，单位为px。参见 [visualMap-piecewise.text](~visualMap-piecewise.text)
-## showLabel(boolean)
+## showLabel(boolean) = true
Review comment:
Left unchanged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] Ovilia commented on a change in pull
request #87: Fix doc
Posted by GitBox <gi...@apache.org>.
Ovilia commented on a change in pull request #87: Fix doc
URL: https://github.com/apache/incubator-echarts-doc/pull/87#discussion_r368786620
##########
File path: zh/option/series/pictorialBar.md
##########
@@ -418,7 +418,7 @@ itemStyle: {
{{ /if }}
-#${prefix} hoverAnimation(boolean) = false
+#${prefix} hoverAnimation(Object)
Review comment:
Left unchanged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] Ovilia merged pull request #87: Fix doc
Posted by GitBox <gi...@apache.org>.
Ovilia merged pull request #87: Fix doc
URL: https://github.com/apache/incubator-echarts-doc/pull/87
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] Ovilia commented on a change in pull
request #87: Fix doc
Posted by GitBox <gi...@apache.org>.
Ovilia commented on a change in pull request #87: Fix doc
URL: https://github.com/apache/incubator-echarts-doc/pull/87#discussion_r368785907
##########
File path: en/option/component/visual-map-piecewise.md
##########
@@ -180,11 +180,11 @@ You can understand the order of items in `text` array just by a simple trial. Se
The rule, that labels will not show when `text` is use, is retained for compatibility with ECharts2.
-## textGap(Array) = 10
+## textGap(number) = 10
The distance between the ends of the graphical elements for pieces and the labels, with unit px. See [visualMap-piecewise.text](~visualMap-piecewise.text)
-## showLabel(boolean)
+## showLabel(boolean) = true
Review comment:
The default value doesn't seem to be `true` according to the text below and [code](https://github.com/apache/incubator-echarts/blob/master/src/component/visualMap/PiecewiseModel.js#L84). I think it should be not changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] Ovilia commented on a change in pull
request #87: Fix doc
Posted by GitBox <gi...@apache.org>.
Ovilia commented on a change in pull request #87: Fix doc
URL: https://github.com/apache/incubator-echarts-doc/pull/87#discussion_r368785018
##########
File path: en/option/component/axis-common.md
##########
@@ -389,8 +389,7 @@ min: function (value) {
}
```
-
-#${prefix} max(number|string) = null
+#${prefix} max(number|string|function) = null
Review comment:
`Function` instead of `function` because `number` and `string` are primary types while `Function` is Object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] Ovilia commented on a change in pull
request #87: Fix doc
Posted by GitBox <gi...@apache.org>.
Ovilia commented on a change in pull request #87: Fix doc
URL: https://github.com/apache/incubator-echarts-doc/pull/87#discussion_r368786366
##########
File path: en/option/series/pictorialBar.md
##########
@@ -429,7 +429,7 @@ Specify the relationship of overlap between gaphic elements. A bigger value mean
{{ /if }}
-#${prefix} hoverAnimation(boolean) = false
+#${prefix} hoverAnimation(Object)
Review comment:
I think this is a boolean and should be left unchanged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts-doc] Ovilia commented on a change in pull
request #87: Fix doc
Posted by GitBox <gi...@apache.org>.
Ovilia commented on a change in pull request #87: Fix doc
URL: https://github.com/apache/incubator-echarts-doc/pull/87#discussion_r368786399
##########
File path: zh/option/component/axis-common.md
##########
@@ -370,7 +370,7 @@ min: function (value) {
其中 `value` 是一个包含 `min` 和 `max` 的对象，分别表示数据的最大最小值，这个函数应该返回坐标轴的最小值。
-#${prefix} max(number|string) = null
+#${prefix} max(number|string|function) = null
Review comment:
`Function`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org