[GitHub] [superset] AAfghahi commented on a diff in pull request #20129: feat(explore): Fill dashboard name when adding new chart from dashboard view

[GitBox <gi...@apache.org>]

AAfghahi commented on code in PR #20129:
URL: https://github.com/apache/superset/pull/20129#discussion_r885740766


##########
superset-frontend/src/dashboard/stylesheets/dashboard.less:
##########
@@ -19,6 +19,7 @@
 /* header has mysterious extra margin */
 header.top {
   margin-bottom: 2px;
+  z-index: 10;

Review Comment:
   why is this necessary?



##########
superset-frontend/src/addSlice/AddSliceContainer.tsx:
##########
@@ -195,10 +198,12 @@ export default class AddSliceContainer extends React.PureComponent<
   }
 
   exploreUrl() {
+    const dashboardId = getUrlParam(URL_PARAMS.dashboardId);
     const formData = encodeURIComponent(
       JSON.stringify({
         viz_type: this.state.visType,
         datasource: this.state.datasource?.value,
+        ...(!isNullish(dashboardId) && { dashboardId }),

Review Comment:
   this is a cool function, why nullish?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org