You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/06/28 08:03:10 UTC
[GitHub] [ozone] wzhallright opened a new pull request #2374: HDDS-5395. Avoid unnecessary numKeyOps.incr() call in OMMetrics
wzhallright opened a new pull request #2374:
URL: https://github.com/apache/ozone/pull/2374
## What changes were proposed in this pull request?
https://issues.apache.org/jira/browse/HDDS-5395?filter=-2
## What is the link to the Apache JIRA
When renaming the key, numkeyOps.incr() is already used in incNumKeyRenames(), so it is not needed in incNumKeyRenameFails().
## How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn merged pull request #2374: HDDS-5395. Avoid unnecessary numKeyOps.incr() call in OMMetrics
Posted by GitBox <gi...@apache.org>.
ayushtkn merged pull request #2374:
URL: https://github.com/apache/ozone/pull/2374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] wzhallright commented on pull request #2374: HDDS-5395. Avoid unnecessary numKeyOps.incr() call in OMMetrics
Posted by GitBox <gi...@apache.org>.
wzhallright commented on pull request #2374:
URL: https://github.com/apache/ozone/pull/2374#issuecomment-870446761
@ayushtkn Thanks for review！
Because I cannot find the usage of incNumS3BucketDeleteFails and incNumListS3BucketsFails, I am not sure whether numBucketOps.incr() needs to be deleted.What is your opinion? Delete or not？
I will trigger new CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ayushtkn commented on pull request #2374: HDDS-5395. Avoid unnecessary numKeyOps.incr() call in OMMetrics
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on pull request #2374:
URL: https://github.com/apache/ozone/pull/2374#issuecomment-871079422
Thanx @wzhallright for the contribution and @bharatviswa504 for the review!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] wzhallright commented on pull request #2374: HDDS-5395. Avoid unnecessary numKeyOps.incr() call in OMMetrics
Posted by GitBox <gi...@apache.org>.
wzhallright commented on pull request #2374:
URL: https://github.com/apache/ozone/pull/2374#issuecomment-870446761
@ayushtkn Thanks for review！
Because I cannot find the usage of incNumS3BucketDeleteFails and incNumListS3BucketsFails, I am not sure whether numBucketOps.incr() needs to be deleted.What is your opinion? Delete or not？
I will trigger new CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org